From: SungEun Kim <cleaneye.kim@lge.com>
To: rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"cleaeye.kim" <cleaneye.kim@lge.com>
Subject: [PATCH] PM / Sleep: Use workqueue for user space wakeup sources garbage collector
Date: Wed, 1 Jul 2015 11:48:58 +0900 [thread overview]
Message-ID: <1435718938-19088-1-git-send-email-cleaneye.kim@lge.com> (raw)
From: "cleaeye.kim" <cleaneye.kim@lge.com>
The synchronous synchronize_rcu in wakeup_source_remove makes user process
which writes to /sys/kernel/wake_unlock blocked sometimes.
For example, when android eventhub tries to release wakelock,
this blocking process can occur, and eventhub can't get input event
for a while.
Using workqueue instead of direct function call at pm_wake_unlock
can prevent this unnecessary delay of an user space process.
Signed-off-by: cleaeye.kim <cleaneye.kim@lge.com>
---
kernel/power/wakelock.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/power/wakelock.c b/kernel/power/wakelock.c
index 019069c..ea10baa 100644
--- a/kernel/power/wakelock.c
+++ b/kernel/power/wakelock.c
@@ -17,6 +17,7 @@
#include <linux/list.h>
#include <linux/rbtree.h>
#include <linux/slab.h>
+#include <linux/workqueue.h>
#include "power.h"
@@ -96,7 +97,7 @@ static inline void wakelocks_lru_most_recent(struct wakelock *wl)
list_move(&wl->lru, &wakelocks_lru_list);
}
-static void wakelocks_gc(void)
+static void wakelocks_gc(struct work_struct *work)
{
struct wakelock *wl, *aux;
ktime_t now;
@@ -105,6 +106,7 @@ static void wakelocks_gc(void)
return;
now = ktime_get();
+ mutex_lock(&wakelocks_lock);
list_for_each_entry_safe_reverse(wl, aux, &wakelocks_lru_list, lru) {
u64 idle_time_ns;
bool active;
@@ -126,12 +128,15 @@ static void wakelocks_gc(void)
decrement_wakelocks_number();
}
}
+ mutex_unlock(&wakelocks_lock);
wakelocks_gc_count = 0;
}
+
+static DECLARE_WORK(wakelock_work, wakelocks_gc);
#else /* !CONFIG_PM_WAKELOCKS_GC */
static inline void wakelocks_lru_add(struct wakelock *wl) {}
static inline void wakelocks_lru_most_recent(struct wakelock *wl) {}
-static inline void wakelocks_gc(void) {}
+static void wakelocks_gc(struct worksturct) {}
#endif /* !CONFIG_PM_WAKELOCKS_GC */
static struct wakelock *wakelock_lookup_add(const char *name, size_t len,
@@ -260,7 +265,7 @@ int pm_wake_unlock(const char *buf)
__pm_relax(&wl->ws);
wakelocks_lru_most_recent(wl);
- wakelocks_gc();
+ schedule_work(&wakelock_work);
out:
mutex_unlock(&wakelocks_lock);
--
1.7.9.5
next reply other threads:[~2015-07-01 2:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 2:48 SungEun Kim [this message]
2015-07-01 3:51 ` Krzysztof Kozlowski
2015-07-01 7:25 ` SungEun Kim(cleaneye.kim@lge.com)
2015-07-01 3:54 ` Krzysztof Kozłowski
2015-07-01 8:28 ` [PATCH v2] " SungEun Kim
2015-07-03 0:15 ` Rafael J. Wysocki
2015-07-03 5:03 ` SungEun Kim(cleaneye.kim@lge.com)
2015-07-15 3:35 ` SungEun Kim(cleaneye.kim@lge.com)
2015-07-03 6:57 ` [PATCH v3] " SungEun Kim
2015-07-16 0:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435718938-19088-1-git-send-email-cleaneye.kim@lge.com \
--to=cleaneye.kim@lge.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®