From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: SungEun Kim <cleaneye.kim@lge.com>
Cc: pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PM / Sleep: Use workqueue for user space wakeup sources garbage collector
Date: Fri, 03 Jul 2015 02:15:49 +0200 [thread overview]
Message-ID: <1544571.4tSqBEqESU@vostro.rjw.lan> (raw)
In-Reply-To: <1435739328-17021-1-git-send-email-cleaneye.kim@lge.com>
On Wednesday, July 01, 2015 05:28:48 PM SungEun Kim wrote:
> From: "SungEun Kim" <cleaneye.kim@lge.com>
>
> The synchronous synchronize_rcu in wakeup_source_remove makes user process
> which writes to /sys/kernel/wake_unlock blocked sometimes.
>
> For example, when android eventhub tries to release wakelock,
> this blocking process can occur, and eventhub can't get input event
> for a while.
>
> Using workqueue instead of direct function call at pm_wake_unlock
> can prevent this unnecessary delay of an user space process.
The idea is defendable, but the patch is too simple.
For example, if the garbage collection is in progress, it is not useful
to start a new one.
Also the incrementation and clearing of wakelocks_gc_count should be under
the lock.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-07-02 23:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 2:48 [PATCH] " SungEun Kim
2015-07-01 3:51 ` Krzysztof Kozlowski
2015-07-01 7:25 ` SungEun Kim(cleaneye.kim@lge.com)
2015-07-01 3:54 ` Krzysztof Kozłowski
2015-07-01 8:28 ` [PATCH v2] " SungEun Kim
2015-07-03 0:15 ` Rafael J. Wysocki [this message]
2015-07-03 5:03 ` SungEun Kim(cleaneye.kim@lge.com)
2015-07-15 3:35 ` SungEun Kim(cleaneye.kim@lge.com)
2015-07-03 6:57 ` [PATCH v3] " SungEun Kim
2015-07-16 0:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544571.4tSqBEqESU@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cleaneye.kim@lge.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®