mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
To: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Martyn Welch <martyn.welch@ge.com>,
	Manohar Vanga <manohar.vanga@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Subject: [PATCH] vme: print unhandled VME access errors
Date: Mon,  6 Jul 2015 17:43:55 +0300	[thread overview]
Message-ID: <1436193835-20154-1-git-send-email-dmitry.kalinkin@gmail.com> (raw)
In-Reply-To: <559A7533.8000408@ge.com>

This will enable error messages for accesses done through mmap.

Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
---
This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset.
---
 drivers/vme/vme.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 7a10d92..72924b0 100644
--- a/drivers/vme/vme.c
+++ b/drivers/vme/vme.c
@@ -1028,6 +1028,7 @@ void vme_bus_error_handler(struct vme_bridge *bridge,
 {
 	struct list_head *handler_pos = NULL;
 	struct vme_error_handler *handler;
+	int handler_triggered = 0;
 	u32 aspace = vme_get_aspace(am);
 
 	list_for_each(handler_pos, &bridge->vme_error_handlers) {
@@ -1040,8 +1041,14 @@ void vme_bus_error_handler(struct vme_bridge *bridge,
 				handler->first_error = address;
 			if (handler->num_errors != UINT_MAX)
 				handler->num_errors++;
+			handler_triggered = 1;
 		}
 	}
+
+	if (!handler_triggered)
+		dev_err(bridge->parent,
+			"Unhandled VME access error at address 0x%llx\n",
+			address);
 }
 EXPORT_SYMBOL(vme_bus_error_handler);
 
-- 
1.8.3.1


  parent reply	other threads:[~2015-07-06 14:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 14:11 [PATCH 0/3] VME bus error handling overhaul Dmitry Kalinkin
2015-07-02 14:11 ` [PATCH 1/3] vme: move tsi148 error handling into VME subsystem Dmitry Kalinkin
2015-07-02 14:11 ` [PATCH 2/3] vme: include address space in error filtering Dmitry Kalinkin
2015-07-02 14:11 ` [PATCH 3/3] vme: change bus error handling scheme Dmitry Kalinkin
2015-07-06 12:31 ` [PATCH 0/3] VME bus error handling overhaul Martyn Welch
2015-07-06 14:20   ` Dmitry Kalinkin
2015-07-06 14:43   ` Dmitry Kalinkin [this message]
2015-07-06 14:50     ` [PATCH] vme: print unhandled VME access errors Martyn Welch
2015-08-05 20:12   ` [PATCH 0/3] VME bus error handling overhaul Greg Kroah-Hartman
2015-09-16 15:39     ` Dmitry Kalinkin
2015-09-16 15:53       ` Greg Kroah-Hartman
2015-09-16 15:55         ` Dmitry Kalinkin
2015-09-16 18:18           ` Dmitry Kalinkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436193835-20154-1-git-send-email-dmitry.kalinkin@gmail.com \
    --to=dmitry.kalinkin@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manohar.vanga@gmail.com \
    --cc=martyn.welch@ge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®