From: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
To: Martyn Welch <martyn.welch@ge.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Igor Alekseev <igor.alekseev@itep.ru>
Subject: Re: [PATCH 0/3] VME bus error handling overhaul
Date: Mon, 6 Jul 2015 17:20:20 +0300 [thread overview]
Message-ID: <E1236DEF-FB74-4E7A-B99A-87145A82048C@gmail.com> (raw)
In-Reply-To: <559A7533.8000408@ge.com>
Hi Martyn,
> On 06 Jul 2015, at 15:31, Martyn Welch <martyn.welch@ge.com> wrote:
>
> These are looking good to me.
Thank you for finding time to look at this and the others.
>
> You mention error handling in relation to vme_master_mmap, am I right in thinking patch 3 avoids errors being recorded when triggered by an mmap access (so as not to appear as a spurious error on a later access)?
Yes, this is covered as well.
>
> I think it would be worth at least logging errors to the kernel log should they be generated and not be handled by a error handler, so someone using mmap gets at least some form of notification that their accesses are resulting on bus errors. What do you think?
Yes. I agree with you. Bus error handler could print a message when an error doesn’t trigger any of the registered handlers.
What would be really useful, is if we could dispatch such errors to the userspace in a more direct way. Not sure how, though.
Cheers,
Dmitry
>
>
> On 02/07/15 15:11, Dmitry Kalinkin wrote:
>> This moves tsi148 error handling into VME subsystem so it can be shared with
>> the other bridge driver. Then there is a change to close a fixme on separating
>> errors by address space. And finally a fix for memory leak problem that was
>> introduced with support of mmap's.
>>
>> The next logical step in this direction would be to add error handling support
>> to ca91cx42 and make it unconditional for tsi148. It also makes much sense to
>> add synchronization to error-related list operations (spinlocks, rcu).
>>
>> Dmitry Kalinkin (3):
>> vme: move tsi148 error handling into VME subsystem
>> vme: include address space in error filtering
>> vme: change bus error handling scheme
>>
>> drivers/vme/bridges/vme_ca91cx42.c | 3 +-
>> drivers/vme/bridges/vme_tsi148.c | 170 ++++++++++---------------------------
>> drivers/vme/vme.c | 83 ++++++++++++++++++
>> drivers/vme/vme_bridge.h | 21 +++--
>> 4 files changed, 147 insertions(+), 130 deletions(-)
>>
>
> --
> Martyn Welch (Lead Software Engineer) | Registered in England and Wales
> GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
> T +44(0)1327322748 | Manchester, M2 3AB
> E martyn.welch@ge.com | VAT:GB 927559189
next prev parent reply other threads:[~2015-07-06 14:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 14:11 Dmitry Kalinkin
2015-07-02 14:11 ` [PATCH 1/3] vme: move tsi148 error handling into VME subsystem Dmitry Kalinkin
2015-07-02 14:11 ` [PATCH 2/3] vme: include address space in error filtering Dmitry Kalinkin
2015-07-02 14:11 ` [PATCH 3/3] vme: change bus error handling scheme Dmitry Kalinkin
2015-07-06 12:31 ` [PATCH 0/3] VME bus error handling overhaul Martyn Welch
2015-07-06 14:20 ` Dmitry Kalinkin [this message]
2015-07-06 14:43 ` [PATCH] vme: print unhandled VME access errors Dmitry Kalinkin
2015-07-06 14:50 ` Martyn Welch
2015-08-05 20:12 ` [PATCH 0/3] VME bus error handling overhaul Greg Kroah-Hartman
2015-09-16 15:39 ` Dmitry Kalinkin
2015-09-16 15:53 ` Greg Kroah-Hartman
2015-09-16 15:55 ` Dmitry Kalinkin
2015-09-16 18:18 ` Dmitry Kalinkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1236DEF-FB74-4E7A-B99A-87145A82048C@gmail.com \
--to=dmitry.kalinkin@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=igor.alekseev@itep.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn.welch@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®