mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jungseok Lee <jungseoklee85@gmail.com>
To: rostedt@goodmis.org, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] tracing: Fix function graph duration format for 7-digit number
Date: Sat, 11 Jul 2015 14:51:39 +0000	[thread overview]
Message-ID: <1436626300-1679-2-git-send-email-jungseoklee85@gmail.com> (raw)
In-Reply-To: <1436626300-1679-1-git-send-email-jungseoklee85@gmail.com>

Currently, row's width of 7-digit duration numbers not aligned with
other cases like the following example.

 3) $ 3999884 us |      }
 3)               |      finish_task_switch() {
 3)   0.365 us    |        _raw_spin_unlock_irq();
 3)   3.333 us    |      }
 3) $ 3999976 us |    }
 3) $ 3999979 us |  } /* schedule */

As adding a single white space in case of 7-digit numbers, the format
could be unified easily as follows.

 3) $ 2237472 us  |      }
 3)               |      finish_task_switch() {
 3)   0.364 us    |        _raw_spin_unlock_irq();
 3)   3.125 us    |      }
 3) $ 2237556 us  |    }
 3) $ 2237559 us  |  } /* schedule */

Signed-off-by: Jungseok Lee <jungseoklee85@gmail.com>
---
 kernel/trace/trace_functions_graph.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index 8968bf7..0bc16c4 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -716,6 +716,8 @@ trace_print_graph_duration(unsigned long long duration, struct trace_seq *s)
 		snprintf(nsecs_str, slen, "%03lu", nsecs_rem);
 		trace_seq_printf(s, ".%s", nsecs_str);
 		len += strlen(nsecs_str);
+	} else if (len == 7) {
+		len -= 1;
 	}
 
 	trace_seq_puts(s, " us ");
-- 
1.9.1


  reply	other threads:[~2015-07-11 14:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-11 14:51 [PATCH 0/2] Improve trace output format Jungseok Lee
2015-07-11 14:51 ` Jungseok Lee [this message]
2015-07-17  1:44   ` [PATCH 1/2] tracing: Fix function graph duration format for 7-digit number Steven Rostedt
2015-07-17 16:29     ` Jungseok Lee
2015-07-11 14:51 ` [PATCH 2/2] tracing: Introduce two additional marks for delay Jungseok Lee
2015-07-21 14:56   ` Jungseok Lee
2015-07-21 15:09     ` Steven Rostedt
2015-07-21 15:17       ` Jungseok Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436626300-1679-2-git-send-email-jungseoklee85@gmail.com \
    --to=jungseoklee85@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®