mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jungseok Lee <jungseoklee85@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
	Byungchul Park <byungchul.park@lge.com>
Subject: Re: [PATCH 2/2] tracing: Introduce two additional marks for delay
Date: Wed, 22 Jul 2015 00:17:09 +0900	[thread overview]
Message-ID: <DF5B19AF-BE3F-44A5-9986-EA3F13F02BE9@gmail.com> (raw)
In-Reply-To: <20150721110944.6c3138ef@gandalf.local.home>

On Jul 22, 2015, at 12:09 AM, Steven Rostedt wrote:
> On Tue, 21 Jul 2015 23:56:31 +0900
> Jungseok Lee <jungseoklee85@gmail.com> wrote:
> 
> 
> 
>> Recently, I've noticed that there is a minor, not logical, flaw in the
>> above hunk as reviewing patches which do not get any signals yet. It is
>> a lack of 's' in msec in comment. That is, my latest one is as follows.
>> 
>> +	MARK(100000000ULL	, '@'), /* 100 msecs */
>> +	MARK(10000000ULL	, '*'), /* 10 msecs */ 
>> 
>> I know it's definitely trivial, but I've updated it to align with other
>> comments and planned to resend the patch. Surprisingly, this patch
>> has been already staged on your repo. So, I leave a whole patch again
>> including your SOB since I don't know how to handle this.
>> 
>> Thanks you for reviewing my patch!
> 
> The original is in the process of going through my tests. I waited till
> rc3 to come out to rebase all my work on it (including this patch) and
> restated testing again. I tripped on some things that are still buggy
> in -rc3 (which delays the finishing of my testing).
> 
> As it is in the testing phase, I wont be modifying it. If you want,
> just send another patch on top of my ftrace/core branch, and I can add
> that to my queue too.

Thanks for a kind explanation.
I think it is not needed to create another patch for only this change.

Best Regards
Jungseok Lee

      reply	other threads:[~2015-07-21 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-11 14:51 [PATCH 0/2] Improve trace output format Jungseok Lee
2015-07-11 14:51 ` [PATCH 1/2] tracing: Fix function graph duration format for 7-digit number Jungseok Lee
2015-07-17  1:44   ` Steven Rostedt
2015-07-17 16:29     ` Jungseok Lee
2015-07-11 14:51 ` [PATCH 2/2] tracing: Introduce two additional marks for delay Jungseok Lee
2015-07-21 14:56   ` Jungseok Lee
2015-07-21 15:09     ` Steven Rostedt
2015-07-21 15:17       ` Jungseok Lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF5B19AF-BE3F-44A5-9986-EA3F13F02BE9@gmail.com \
    --to=jungseoklee85@gmail.com \
    --cc=byungchul.park@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®