From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Guillaume Bienkowski <guitreize@gmail.com>,
luca@lucaceresoli.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Fix style errors and warnings
Date: Thu, 16 Jul 2015 12:12:37 -0700 [thread overview]
Message-ID: <1437073957.2495.32.camel@perches.com> (raw)
In-Reply-To: <20150716171134.GA13728@kroah.com>
On Thu, 2015-07-16 at 10:11 -0700, Greg KH wrote:
> On Thu, Jul 16, 2015 at 09:41:36AM +0200, Guillaume Bienkowski wrote:
> > Fix spaces before comma and indentation.
>
> That's two different things, so this should be two different patches
> please.
I think it'd be better to do all the whitespace changes
in a single go:
$ git ls-files drivers/staging/rtl8188eu | \
xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing,space_before_tab,pointer_location,trailing_whitespace,bracket_space --strict
and submit the git diff with "whitespace style changes"
after verifying that objdiff shows no changes.
64 files changed, 1240 insertions(+), 1240 deletions(-)
It's ~330KB patch though.
prev parent reply other threads:[~2015-07-16 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 7:41 Guillaume Bienkowski
2015-07-16 17:11 ` Greg KH
2015-07-16 19:12 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437073957.2495.32.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=guitreize@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®