mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, cooloney@gmail.com,
	rpurdie@rpsys.net, stsp@users.sourceforge.net,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Pavel Machek <pavel@ucw.cz>
Subject: [PATCH/RFC 03/51] leds: Add an internal led_set_brightness_nosleep function
Date: Fri, 17 Jul 2015 10:46:49 +0200	[thread overview]
Message-ID: <1437122857-6765-4-git-send-email-j.anaszewski@samsung.com> (raw)
In-Reply-To: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com>

This patch adds led_set_brightness_nosleep function as well
as LED_BRIGHTNESS_FAST flag. The flag, when set by a driver
means that its brightness_set op is guaranteed not to sleep.
Basing on this information the function decides whether
brightness should be set in an asynchronous or synchronous
way.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Bryan Wu <cooloney@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Stas Sergeev <stsp@users.sourceforge.net>
---
 drivers/leds/leds.h  |   18 ++++++++++++++++++
 include/linux/leds.h |    3 ++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds.h b/drivers/leds/leds.h
index ca38f6a..6c56142 100644
--- a/drivers/leds/leds.h
+++ b/drivers/leds/leds.h
@@ -2,8 +2,10 @@
  * LED Core
  *
  * Copyright 2005 Openedhand Ltd.
+ * Copyright 2014, 2015 Samsung Electronics Co., Ltd.
  *
  * Author: Richard Purdie <rpurdie@openedhand.com>
+ * Author: Jacek Anaszewski <j.anaszewski@samsung.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
@@ -23,6 +25,22 @@ static inline void led_set_brightness_async(struct led_classdev *led_cdev,
 	schedule_work(&led_cdev->set_brightness_work);
 }
 
+static inline void led_set_brightness_nosleep(struct led_classdev *led_cdev,
+					      enum led_brightness value)
+{
+	if (led_cdev->flags & LED_BRIGHTNESS_FAST) {
+		led_set_brightness_sync(led_cdev, value);
+		return;
+	}
+
+	/*
+	 * Delegate setting brightness to a work queue task only for slow
+	 * LEDs as the FAST ones are guaranteed not to sleep while setting
+	 * brightness.
+	 */
+	led_set_brightness_async(led_cdev, value);
+}
+
 static inline int led_get_brightness(struct led_classdev *led_cdev)
 {
 	return led_cdev->brightness;
diff --git a/include/linux/leds.h b/include/linux/leds.h
index a72ab56..2fdfc13 100644
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -49,9 +49,10 @@ struct led_classdev {
 #define SET_BRIGHTNESS_SYNC	(1 << 22)
 #define LED_DEV_CAP_FLASH	(1 << 23)
 #define LED_BLINK_DISABLE	(1 << 24)
+#define LED_BRIGHTNESS_FAST	(1 << 25)
 
 	/* Set LED brightness level */
-	/* Must not sleep, use a workqueue if needed */
+	/* Must not sleep if the driver sets LED_BRIGHTNESS_FAST flag */
 	void		(*brightness_set)(struct led_classdev *led_cdev,
 					  enum led_brightness brightness);
 	/*
-- 
1.7.9.5


  parent reply	other threads:[~2015-07-17  9:15 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17  8:46 [PATCH/RFC v4 00/51] Remove work queues from LED class drivers Jacek Anaszewski
2015-07-17  8:46 ` [PATCH/RFC 01/51] leds: Add led_set_brightness_sync to the public LED subsystem API Jacek Anaszewski
2015-07-21  9:50   ` Pavel Machek
2015-07-21 15:43     ` Jacek Anaszewski
2015-07-22  7:25       ` Pavel Machek
2015-07-17  8:46 ` [PATCH/RFC 02/51] leds: Improve asynchronous path of setting brightness Jacek Anaszewski
2015-07-17  8:46 ` Jacek Anaszewski [this message]
2015-07-21  9:53   ` [PATCH/RFC 03/51] leds: Add an internal led_set_brightness_nosleep function Pavel Machek
2015-07-21 15:43     ` Jacek Anaszewski
2015-07-21 21:30       ` Pavel Machek
2015-07-17  8:46 ` [PATCH/RFC 04/51] leds: Improve setting brightness in a non sleeping way Jacek Anaszewski
2015-07-17  8:46 ` [PATCH/RFC 05/51] leds: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski
2015-07-17  8:46 ` [PATCH/RFC 06/51] media: flash: use led_set_brightness_sync for torch brightness Jacek Anaszewski
2015-07-17  8:46 ` [PATCH/RFC 07/51] leds: tlc591xx: Remove work queue Jacek Anaszewski
2015-07-17  8:46 ` [PATCH/RFC 08/51] leds: 88pm860x: " Jacek Anaszewski
2015-07-17  8:46 ` [PATCH/RFC 09/51] leds: adp5520: " Jacek Anaszewski
2015-07-17  8:52   ` Michael Hennerich
2015-07-17  8:46 ` [PATCH/RFC 10/51] leds: bd2802: " Jacek Anaszewski
2015-07-17  8:46 ` [PATCH/RFC 11/51] leds: blinkm: " Jacek Anaszewski
2015-07-17  8:46 ` [PATCH/RFC 12/51] leds: lm3533: " Jacek Anaszewski
2015-07-17  9:20   ` Johan Hovold
2015-07-17  8:46 ` [PATCH/RFC 13/51] leds: lm3642: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 14/51] leds: pca9532: Remove work queue for LEDs Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 15/51] leds: lp3944: Remove work queue Jacek Anaszewski
2015-07-22  9:45   ` Antonio Ospite
2015-07-17  8:47 ` [PATCH/RFC 16/51] leds: lp55xx: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 17/51] leds: lp8788: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 18/51] leds: lp8860: " Jacek Anaszewski
2015-07-17 13:52   ` Dan Murphy
2015-07-17  8:47 ` [PATCH/RFC 19/51] leds: pca955x: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 20/51] leds: pca963x: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 21/51] leds: wm831x: " Jacek Anaszewski
2015-07-17 10:02   ` Mark Brown
2015-07-17  8:47 ` [PATCH/RFC 22/51] leds: da903x: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 23/51] leds: da9052: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 24/51] leds: dac124d085: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 25/51] leds: lt3593: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 26/51] leds: max8997: Remove unneeded workqueue include Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 27/51] leds: mc13783: Remove work queue Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 28/51] leds: regulator: " Jacek Anaszewski
2015-07-22 10:03   ` Antonio Ospite
2015-07-17  8:47 ` [PATCH/RFC 29/51] leds: wm8350: " Jacek Anaszewski
2015-07-17 10:02   ` Mark Brown
2015-07-17  8:47 ` [PATCH/RFC 30/51] leds: pwm: remove " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 31/51] leds: lm355x: Remove " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 32/51] leds: gpio: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 33/51] leds: cobalt-raq: Mark the LED fast Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 34/51] leds: bcm6328: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 35/51] leds: bcm6358: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 36/51] leds: syscon: " Jacek Anaszewski
2015-07-17 13:41   ` Linus Walleij
2015-07-17  8:47 ` [PATCH/RFC 37/51] leds: ot200: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 38/51] leds: s3c24xx: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 39/51] leds: ss4200: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 40/51] leds: versatile: " Jacek Anaszewski
2015-07-17 13:42   ` Linus Walleij
2015-07-17  8:47 ` [PATCH/RFC 41/51] leds: wrap: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 42/51] leds: net48xx: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 43/51] leds: asic3: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 44/51] leds: cobalt-qube: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 45/51] leds: fsg: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 46/51] leds: hp6xx: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 47/51] leds: locomo: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 48/51] leds: dell: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 49/51] leds: rb532: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 50/51] leds: sunfire: " Jacek Anaszewski
2015-07-17  8:47 ` [PATCH/RFC 51/51] leds: ipaq-micro: " Jacek Anaszewski
2015-07-17 13:43   ` Linus Walleij
2015-07-17 15:37     ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437122857-6765-4-git-send-email-j.anaszewski@samsung.com \
    --to=j.anaszewski@samsung.com \
    --cc=andrew@lunn.ch \
    --cc=cooloney@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stsp@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®