From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, cooloney@gmail.com,
rpurdie@rpsys.net, stsp@users.sourceforge.net,
Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH/RFC 08/51] leds: 88pm860x: Remove work queue
Date: Fri, 17 Jul 2015 10:46:54 +0200 [thread overview]
Message-ID: <1437122857-6765-9-git-send-email-j.anaszewski@samsung.com> (raw)
In-Reply-To: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com>
From: Andrew Lunn <andrew@lunn.ch>
Now the core implements the work queue, remove it from the driver.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/leds/leds-88pm860x.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
index 1497a09..fb29848 100644
--- a/drivers/leds/leds-88pm860x.c
+++ b/drivers/leds/leds-88pm860x.c
@@ -16,7 +16,6 @@
#include <linux/i2c.h>
#include <linux/leds.h>
#include <linux/slab.h>
-#include <linux/workqueue.h>
#include <linux/mfd/88pm860x.h>
#include <linux/module.h>
@@ -33,7 +32,6 @@
struct pm860x_led {
struct led_classdev cdev;
struct i2c_client *i2c;
- struct work_struct work;
struct pm860x_chip *chip;
struct mutex lock;
char name[MFD_NAME_SIZE];
@@ -69,17 +67,18 @@ static int led_power_set(struct pm860x_chip *chip, int port, int on)
return ret;
}
-static void pm860x_led_work(struct work_struct *work)
+static void pm860x_led_set(struct led_classdev *cdev,
+ enum led_brightness value)
{
-
- struct pm860x_led *led;
+ struct pm860x_led *led = container_of(cdev, struct pm860x_led, cdev);
struct pm860x_chip *chip;
unsigned char buf[3];
int ret;
- led = container_of(work, struct pm860x_led, work);
chip = led->chip;
mutex_lock(&led->lock);
+ led->brightness = value >> 3;
+
if ((led->current_brightness == 0) && led->brightness) {
led_power_set(chip, led->port, 1);
if (led->iset) {
@@ -114,15 +113,6 @@ static void pm860x_led_work(struct work_struct *work)
mutex_unlock(&led->lock);
}
-static void pm860x_led_set(struct led_classdev *cdev,
- enum led_brightness value)
-{
- struct pm860x_led *data = container_of(cdev, struct pm860x_led, cdev);
-
- data->brightness = value >> 3;
- schedule_work(&data->work);
-}
-
#ifdef CONFIG_OF
static int pm860x_led_dt_init(struct platform_device *pdev,
struct pm860x_led *data)
@@ -214,7 +204,6 @@ static int pm860x_led_probe(struct platform_device *pdev)
data->cdev.name = data->name;
data->cdev.brightness_set = pm860x_led_set;
mutex_init(&data->lock);
- INIT_WORK(&data->work, pm860x_led_work);
ret = led_classdev_register(chip->dev, &data->cdev);
if (ret < 0) {
--
1.7.9.5
next prev parent reply other threads:[~2015-07-17 8:48 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 8:46 [PATCH/RFC v4 00/51] Remove work queues from LED class drivers Jacek Anaszewski
2015-07-17 8:46 ` [PATCH/RFC 01/51] leds: Add led_set_brightness_sync to the public LED subsystem API Jacek Anaszewski
2015-07-21 9:50 ` Pavel Machek
2015-07-21 15:43 ` Jacek Anaszewski
2015-07-22 7:25 ` Pavel Machek
2015-07-17 8:46 ` [PATCH/RFC 02/51] leds: Improve asynchronous path of setting brightness Jacek Anaszewski
2015-07-17 8:46 ` [PATCH/RFC 03/51] leds: Add an internal led_set_brightness_nosleep function Jacek Anaszewski
2015-07-21 9:53 ` Pavel Machek
2015-07-21 15:43 ` Jacek Anaszewski
2015-07-21 21:30 ` Pavel Machek
2015-07-17 8:46 ` [PATCH/RFC 04/51] leds: Improve setting brightness in a non sleeping way Jacek Anaszewski
2015-07-17 8:46 ` [PATCH/RFC 05/51] leds: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski
2015-07-17 8:46 ` [PATCH/RFC 06/51] media: flash: use led_set_brightness_sync for torch brightness Jacek Anaszewski
2015-07-17 8:46 ` [PATCH/RFC 07/51] leds: tlc591xx: Remove work queue Jacek Anaszewski
2015-07-17 8:46 ` Jacek Anaszewski [this message]
2015-07-17 8:46 ` [PATCH/RFC 09/51] leds: adp5520: " Jacek Anaszewski
2015-07-17 8:52 ` Michael Hennerich
2015-07-17 8:46 ` [PATCH/RFC 10/51] leds: bd2802: " Jacek Anaszewski
2015-07-17 8:46 ` [PATCH/RFC 11/51] leds: blinkm: " Jacek Anaszewski
2015-07-17 8:46 ` [PATCH/RFC 12/51] leds: lm3533: " Jacek Anaszewski
2015-07-17 9:20 ` Johan Hovold
2015-07-17 8:46 ` [PATCH/RFC 13/51] leds: lm3642: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 14/51] leds: pca9532: Remove work queue for LEDs Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 15/51] leds: lp3944: Remove work queue Jacek Anaszewski
2015-07-22 9:45 ` Antonio Ospite
2015-07-17 8:47 ` [PATCH/RFC 16/51] leds: lp55xx: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 17/51] leds: lp8788: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 18/51] leds: lp8860: " Jacek Anaszewski
2015-07-17 13:52 ` Dan Murphy
2015-07-17 8:47 ` [PATCH/RFC 19/51] leds: pca955x: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 20/51] leds: pca963x: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 21/51] leds: wm831x: " Jacek Anaszewski
2015-07-17 10:02 ` Mark Brown
2015-07-17 8:47 ` [PATCH/RFC 22/51] leds: da903x: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 23/51] leds: da9052: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 24/51] leds: dac124d085: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 25/51] leds: lt3593: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 26/51] leds: max8997: Remove unneeded workqueue include Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 27/51] leds: mc13783: Remove work queue Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 28/51] leds: regulator: " Jacek Anaszewski
2015-07-22 10:03 ` Antonio Ospite
2015-07-17 8:47 ` [PATCH/RFC 29/51] leds: wm8350: " Jacek Anaszewski
2015-07-17 10:02 ` Mark Brown
2015-07-17 8:47 ` [PATCH/RFC 30/51] leds: pwm: remove " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 31/51] leds: lm355x: Remove " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 32/51] leds: gpio: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 33/51] leds: cobalt-raq: Mark the LED fast Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 34/51] leds: bcm6328: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 35/51] leds: bcm6358: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 36/51] leds: syscon: " Jacek Anaszewski
2015-07-17 13:41 ` Linus Walleij
2015-07-17 8:47 ` [PATCH/RFC 37/51] leds: ot200: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 38/51] leds: s3c24xx: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 39/51] leds: ss4200: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 40/51] leds: versatile: " Jacek Anaszewski
2015-07-17 13:42 ` Linus Walleij
2015-07-17 8:47 ` [PATCH/RFC 41/51] leds: wrap: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 42/51] leds: net48xx: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 43/51] leds: asic3: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 44/51] leds: cobalt-qube: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 45/51] leds: fsg: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 46/51] leds: hp6xx: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 47/51] leds: locomo: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 48/51] leds: dell: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 49/51] leds: rb532: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 50/51] leds: sunfire: " Jacek Anaszewski
2015-07-17 8:47 ` [PATCH/RFC 51/51] leds: ipaq-micro: " Jacek Anaszewski
2015-07-17 13:43 ` Linus Walleij
2015-07-17 15:37 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437122857-6765-9-git-send-email-j.anaszewski@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=andrew@lunn.ch \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=stsp@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®