mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Rik van Riel <riel@redhat.com>,
	"Luis Claudio R. Goncalves" <lclaudio@uudg.org>
Subject: Re: [RFC] workqueue: avoiding unbounded wq on isolated CPUs by default
Date: Sat, 18 Jul 2015 17:48:56 +0200	[thread overview]
Message-ID: <1437234536.3452.71.camel@gmail.com> (raw)
In-Reply-To: <20150718133602.GA3041@lerouge>

On Sat, 2015-07-18 at 15:36 +0200, Frederic Weisbecker wrote:
> On Fri, Jul 17, 2015 at 07:15:48PM +0200, Mike Galbraith wrote:
> > On Fri, 2015-07-17 at 11:27 -0400, Tejun Heo wrote:
> > 
> > > I'm just curious whether there was any specific reason we didn't do
> > > this before (ISTR people discussing it back then too).
> > 
> > I'm dead set against all this auto-presume nonsense fwtw  Allocating a
> > pool of no_hz_full _capable_ CPUs should not entice the kernel to make
> > any rash assumptions.  Let users do the button poking, they know what
> > they want, and when they want it.
> 
> We need to make a choice then. Either we do all the affinity tuning from
> userspace with a common tool, which is what I had wished before everybody
> asked for pre-settings.

Giving userspace what they need to do what they want seems right to me.

> Or we do it in the kernel, now we should define some kind of CONFIG_ISOLATION
> to make that proper and rule the various kinds of isolation people are
> interested in.
> 
> But we can't leave it half-way like it is currently with everything preset on
> top of nohz: rcu nocb mask, watchdog mask, cpu_isolation_map and exclude workqueue.

Yeah.  Hell, maybe I'm wrong.  Maybe people really want this rigidity
and hand-holding by the kernel, but it just seems dainbramaged to me.
ATM, you pay a high price (the overhead) for the capability, but until
that auto-assume isolcpus landed, those CPUs weren't forever more
specialists, they were CPUs with an extra (costly) capability, could be
disconnected/reconnected to load balancing on the fly, and used however
the user saw fit.

I can imagine an auto-everything kernel having a bit of trouble with an
SGI beast from hell.  Too bad I don't have access to one, I'd try to
boot a tune for maximum hand holding kernel.

	-Mike


  reply	other threads:[~2015-07-18 15:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 19:16 Daniel Bristot de Oliveira
2015-07-16 19:24 ` Tejun Heo
2015-07-17  4:26   ` Mike Galbraith
2015-07-17 15:27     ` Tejun Heo
2015-07-17 15:35       ` Frederic Weisbecker
2015-07-17 15:43         ` Tejun Heo
2015-07-17 17:15       ` Mike Galbraith
2015-07-18 13:36         ` Frederic Weisbecker
2015-07-18 15:48           ` Mike Galbraith [this message]
2015-07-19  8:02           ` Mike Galbraith
2015-07-19 12:19             ` Mike Galbraith
2015-07-21  8:55             ` Mike Galbraith
2015-07-22  5:24               ` [patch] workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs Mike Galbraith
2015-07-22 12:43                 ` [PATCH] workqueue: avoiding unbounded wq on isolated CPUs by default Daniel Bristot de Oliveira
2015-07-22 14:11                 ` [patch] workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs Tejun Heo
2015-07-22 14:55                   ` Mike Galbraith
2015-07-22 15:19                     ` Mike Galbraith
2015-07-22 15:25                       ` Tejun Heo
2015-07-24  3:38                         ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437234536.3452.71.camel@gmail.com \
    --to=umgwanakikbuti@gmail.com \
    --cc=bristot@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=lclaudio@uudg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome