mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Rik van Riel <riel@redhat.com>,
	"Luis Claudio R. Goncalves" <lclaudio@uudg.org>
Subject: Re: [RFC] workqueue: avoiding unbounded wq on isolated CPUs by default
Date: Fri, 17 Jul 2015 17:35:09 +0200	[thread overview]
Message-ID: <20150717153507.GB20260@lerouge> (raw)
In-Reply-To: <20150717152720.GD15934@mtj.duckdns.org>

On Fri, Jul 17, 2015 at 11:27:20AM -0400, Tejun Heo wrote:
> Hello, Mike.
> 
> On Fri, Jul 17, 2015 at 06:26:30AM +0200, Mike Galbraith wrote:
> > Hm, I thought the plan was that after the Lai's unbound series landed,
> > his ordered wq patch would follow, but perhaps not.
> 
> Yes, that still is the plan but this is kinda unrelated to that
> change.  This just initializes wq cpumask according to cpu isolation.
> I'm just curious whether there was any specific reason we didn't do
> this before (ISTR people discussing it back then too).

Initializing wq unbound cpumask to housekeeping_mask is still the
plan. I just remember we didn't do it in Lai's series because it
was slightly unrelated. When a patchset is complicated, like Lai's,
it's better to keep it focus to a single purpose.

Anyway that patch is welcome.

> 
> > I'm referring to the somewhat aged patch below. (freshly wedged into
> > master, and maybe not properly, but it should at least look familiar).
> 
> Yeah, I think I asked Lai to try a different approach where we
> regulate it from queueing path rather than playing with pwqs.  I think
> that'd end up quite a bit simpler.

Ordered workqueues aren't handled currently? I tried setting the unbound
cpumask and it also applied to khelper which is a singlethread (and thus
ordered) workqueue.

> Thanks.
> 
> -- 
> tejun

  reply	other threads:[~2015-07-17 15:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 19:16 Daniel Bristot de Oliveira
2015-07-16 19:24 ` Tejun Heo
2015-07-17  4:26   ` Mike Galbraith
2015-07-17 15:27     ` Tejun Heo
2015-07-17 15:35       ` Frederic Weisbecker [this message]
2015-07-17 15:43         ` Tejun Heo
2015-07-17 17:15       ` Mike Galbraith
2015-07-18 13:36         ` Frederic Weisbecker
2015-07-18 15:48           ` Mike Galbraith
2015-07-19  8:02           ` Mike Galbraith
2015-07-19 12:19             ` Mike Galbraith
2015-07-21  8:55             ` Mike Galbraith
2015-07-22  5:24               ` [patch] workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs Mike Galbraith
2015-07-22 12:43                 ` [PATCH] workqueue: avoiding unbounded wq on isolated CPUs by default Daniel Bristot de Oliveira
2015-07-22 14:11                 ` [patch] workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs Tejun Heo
2015-07-22 14:55                   ` Mike Galbraith
2015-07-22 15:19                     ` Mike Galbraith
2015-07-22 15:25                       ` Tejun Heo
2015-07-24  3:38                         ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150717153507.GB20260@lerouge \
    --to=fweisbec@gmail.com \
    --cc=bristot@redhat.com \
    --cc=jiangshanlai@gmail.com \
    --cc=lclaudio@uudg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@redhat.com \
    --cc=tj@kernel.org \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®