From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Ying Huang <ying.huang@intel.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH] parport: Revert "parport: fix memory leak"
Date: Sat, 25 Jul 2015 13:19:40 +0530 [thread overview]
Message-ID: <1437810580-1747-1-git-send-email-sudipm.mukherjee@gmail.com> (raw)
This reverts commit 23c405912b88 ("parport: fix memory leak")
par_dev->state was already being removed in parport_unregister_device().
Reported-by: Ying Huang <ying.huang@intel.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
But I am surprised at two points:
1) Why the error came while loading the gs_fpgaboot module?
Maybe the double freeing has freed some memory which fpga was
using.
2) Why the dmesg showed "panel: could not claim access to parport0. Aborting."?
Because of 50566ac87065 ("parport: check exclusive access before
register") the panel driver should not even register and it
should have failed at parport_register_dev_model().
drivers/parport/share.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index c02b5f2..5ce5ef2 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -816,7 +816,6 @@ static void free_pardevice(struct device *dev)
struct pardevice *par_dev = to_pardevice(dev);
kfree(par_dev->name);
- kfree(par_dev->state);
kfree(par_dev);
}
--
1.9.1
next reply other threads:[~2015-07-25 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 7:49 Sudip Mukherjee [this message]
2015-07-25 17:22 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437810580-1747-1-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®