mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: checkpatch warns about Fixes: lines
Date: Fri, 31 Jul 2015 14:24:46 +0200	[thread overview]
Message-ID: <1438345486.13223.19.camel@tiscali.nl> (raw)

Andy, Joe,

Checkpatch (as shipped in today's linux-next) warns about "Fixes:"
lines:

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
Fixes: 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")'
#10: 
Fixes: 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")

total: 1 errors, 1 warnings, 8 lines checked

Your patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Both warnings seem false positives. "Fixes:" lines should be one line,
shouldn't they, and I think I did use the correct commit description
style here.

Thanks,


Paul Bolle

             reply	other threads:[~2015-07-31 12:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 12:24 Paul Bolle [this message]
2015-07-31 22:54 ` [PATCH] checkpatch: Avoid some commit message long line warnings Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438345486.13223.19.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome