mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] Lustre: remove cfs_daemonize from comments
@ 2015-08-04  1:57 green
  2015-08-04  1:57 ` [PATCH 1/2] staging/lustre/ptlrpc: Remove stray cfs_daemonize comment green
  2015-08-04  1:57 ` [PATCH 2/2] staging/lustre: Properly reference kthread_run instead of cfs_daemonize green
  0 siblings, 2 replies; 3+ messages in thread
From: green @ 2015-08-04  1:57 UTC (permalink / raw)
  To: Greg Kroah-Hartman, devel, Andreas Dilger
  Cc: Linux Kernel Mailing List, Oleg Drokin

From: Oleg Drokin <green@linuxhacker.ru>

cfs_daemonize was removed long ago, but I just stumbled upon
a couple of instances where it was still referenced in the comments,
so here are the patches to clean it up and not cause any unnecessary
confusion.

Oleg Drokin (2):
  staging/lustre/ptlrpc: Remove stray daemonize comment
  staging/lustre: Properly reference kthread_run instead of
    cfs_daemonize

 drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-
 drivers/staging/lustre/lustre/ptlrpc/pinger.c      | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

-- 
2.1.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] staging/lustre/ptlrpc: Remove stray cfs_daemonize comment
  2015-08-04  1:57 [PATCH 0/2] Lustre: remove cfs_daemonize from comments green
@ 2015-08-04  1:57 ` green
  2015-08-04  1:57 ` [PATCH 2/2] staging/lustre: Properly reference kthread_run instead of cfs_daemonize green
  1 sibling, 0 replies; 3+ messages in thread
From: green @ 2015-08-04  1:57 UTC (permalink / raw)
  To: Greg Kroah-Hartman, devel, Andreas Dilger
  Cc: Linux Kernel Mailing List, Oleg Drokin

From: Oleg Drokin <green@linuxhacker.ru>

Ever since daemonize was removed in 3.18, there are no longer
any flags passed to kthread_run.
Most of the comments were deleted, but this one lingered on
until now.

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
 drivers/staging/lustre/lustre/ptlrpc/pinger.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/pinger.c b/drivers/staging/lustre/lustre/ptlrpc/pinger.c
index d05c37c..f8edb79 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/pinger.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/pinger.c
@@ -318,8 +318,6 @@ int ptlrpc_start_pinger(void)
 
 	strcpy(pinger_thread.t_name, "ll_ping");
 
-	/* CLONE_VM and CLONE_FILES just avoid a needless copy, because we
-	 * just drop the VM and FILES in cfs_daemonize_ctxt() right away. */
 	rc = PTR_ERR(kthread_run(ptlrpc_pinger_main, &pinger_thread,
 				 "%s", pinger_thread.t_name));
 	if (IS_ERR_VALUE(rc)) {
-- 
2.1.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] staging/lustre: Properly reference kthread_run instead of cfs_daemonize
  2015-08-04  1:57 [PATCH 0/2] Lustre: remove cfs_daemonize from comments green
  2015-08-04  1:57 ` [PATCH 1/2] staging/lustre/ptlrpc: Remove stray cfs_daemonize comment green
@ 2015-08-04  1:57 ` green
  1 sibling, 0 replies; 3+ messages in thread
From: green @ 2015-08-04  1:57 UTC (permalink / raw)
  To: Greg Kroah-Hartman, devel, Andreas Dilger
  Cc: Linux Kernel Mailing List, Oleg Drokin

From: Oleg Drokin <green@linuxhacker.ru>

cfs_daemonize is long gone and replaced by a proper call to kthread_run,
so update the comment to reflect that fact.

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
 drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre_net.h b/drivers/staging/lustre/lustre/include/lustre_net.h
index 77a7de9..3bb2f8b 100644
--- a/drivers/staging/lustre/lustre/include/lustre_net.h
+++ b/drivers/staging/lustre/lustre/include/lustre_net.h
@@ -2183,7 +2183,7 @@ struct ptlrpcd_ctl {
 	 */
 	struct ptlrpc_request_set  *pc_set;
 	/**
-	 * Thread name used in cfs_daemonize()
+	 * Thread name used in kthread_run()
 	 */
 	char			pc_name[16];
 	/**
-- 
2.1.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-04  1:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-04  1:57 [PATCH 0/2] Lustre: remove cfs_daemonize from comments green
2015-08-04  1:57 ` [PATCH 1/2] staging/lustre/ptlrpc: Remove stray cfs_daemonize comment green
2015-08-04  1:57 ` [PATCH 2/2] staging/lustre: Properly reference kthread_run instead of cfs_daemonize green

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®