mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chenhui Zhao <chenhui.zhao@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: <b29983@freescale.com>, <b07421@freescale.com>,
	<linux-kernel@vger.kernel.org>,
	Tang Yuantian <Yuantian.Tang@freescale.com>,
	<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/3] PowerPC/mpc85xx: Add hotplug support on E5500 and E500MC cores
Date: Wed, 5 Aug 2015 18:39:46 +0800	[thread overview]
Message-ID: <1438771186.21522.1@remotesmtp.freescale.net> (raw)
In-Reply-To: <1438636720.2097.63.camel@freescale.com>



On Tue, Aug 4, 2015 at 5:18 AM, Scott Wood <scottwood@freescale.com> 
wrote:
> [Added linuxppc-dev@lists.ozlabs.org.  Besides that list being 
> required for
> review of PPC patches, it feeds the patchwork that I use to track and 
> apply
> patches.]
> 
> On Mon, 2015-08-03 at 19:52 +0800, Chenhui Zhao wrote:
>>  On Sat, Aug 1, 2015 at 8:14 AM, Scott Wood <scottwood@freescale.com>
>>  wrote:
>>  > On Fri, 2015-07-31 at 17:20 +0800,  b29983@freescale.comwrote:
>>  > >  From: Tang Yuantian <Yuantian.Tang@freescale.com>
>>  > >
>>  > >  Freescale E500MC and E5500 core-based platforms, like P4080, 
>> T1040,
>>  > >  support disabling/enabling CPU dynamically.
>>  > >  This patch adds this feature on those platforms.
>>  > >
>>  > >  Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
>>  > >  Signed-off-by: Tang Yuantian <Yuantian.Tang@feescale.com>


>>  +{
>>  > >  +     int i;
>>  > >  +
>>  > >  +     for (i = 0; i < 50000; i++) {
>>  > >  +             if (generic_check_cpu_dead(cpu)) {
>>  > >  +                     qoriq_pm_ops->cpu_die(cpu);
>>  > >  +#ifdef CONFIG_PPC64
>>  > >  +                     paca[cpu].cpu_start = 0;
>>  > >  +#endif
>>  > >  +                     return;
>>  > >  +             }
>>  > >  +             udelay(10);
>>  > >  +     }
>>  > >  +     pr_err("%s: CPU%d didn't die...\n", __func__, cpu);
>>  > >  +}
>>  >
>>  > Only 500ms timeout, versus 10sec in generic_cpu_die()?
>> 
>>  The process is fast. Maybe 10 second is too large.
> 
> Is it fast 100% of the time?  What if the CPU you intend to die is in 
> a long
> critical section?  What harm is there to having a longer timeout, 
> similar to
> what other platforms use?

Will change the max timeout to 10 seconds.

> 
>> 
>>  >
>>  > >   #endif
>>  > >
>>  > >   static inline void flush_spin_table(void *spin_table)
>>  > >  @@ -246,11 +267,7 @@ static int smp_85xx_kick_cpu(int nr)
>>  > >                spin_table = phys_to_virt(*cpu_rel_addr);
>>  > >
>>  > >        local_irq_save(flags);
>>  > >  -#ifdef CONFIG_PPC32
>>  > >   #ifdef CONFIG_HOTPLUG_CPU
>>  > >  -     /* Corresponding to generic_set_cpu_dead() */
>>  > >  -     generic_set_cpu_up(nr);
>>  > >  -
>>  > >        if (system_state == SYSTEM_RUNNING) {
>>  > >                /*
>>  > >                 * To keep it compatible with old boot program 
>> which
>>  > > uses
>>  > >  @@ -263,6 +280,7 @@ static int smp_85xx_kick_cpu(int nr)
>>  > >                out_be32(&spin_table->addr_l, 0);
>>  > >                flush_spin_table(spin_table);
>>  > >
>>  > >  +             qoriq_pm_ops->cpu_up(nr);
>>  >
>>  > Again, is it possible to get here without a valid qoriq_pm_ops 
>> (i.e.
>>  > is there
>>  > anything stopping the user from trying to initiate CPU hotplug)?
>>  >
>>  > -Scott
>> 
>>  For every platform running this code, should has a valid 
>> qoriq_pm_ops.
>>  If not valid, it's a bug.
> 
> How do you prevent this code from running when there is no valid 
> qoriq_pm_ops?
> 
> -Scott
> 

Will check if qoriq_pm_ops is valid.

-Chenhui




  reply	other threads:[~2015-08-05 10:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31  9:20 [PATCH 1/3] Powerpc: mpc85xx: refactor the PM operations b29983
2015-07-31  9:20 ` [PATCH 2/3] PowerPC/mpc85xx: Add hotplug support on E5500 and E500MC cores b29983
2015-08-01  0:14   ` Scott Wood
2015-08-03 11:52     ` Chenhui Zhao
2015-08-03 21:18       ` Scott Wood
2015-08-05 10:39         ` Chenhui Zhao [this message]
2015-07-31  9:20 ` [PATCH 3/3] PowerPC/mpc85xx: Add hotplug support on E6500 cores b29983
2015-08-01  0:22   ` Scott Wood
2015-08-05 11:08     ` Chenhui Zhao
2015-08-06  3:16       ` Scott Wood
2015-08-06  4:32         ` Chenhui Zhao
2015-08-06  5:44           ` Scott Wood
2015-07-31 23:59 ` [PATCH 1/3] Powerpc: mpc85xx: refactor the PM operations Scott Wood
2015-08-03 11:32   ` Chenhui Zhao
2015-08-03 20:26     ` Scott Wood
2015-08-05 10:11       ` Chenhui Zhao
2015-08-06  2:57         ` Scott Wood
2015-08-06  4:20           ` Chenhui Zhao
2015-08-06  5:46             ` Scott Wood
2015-08-06  5:54               ` Chenhui Zhao
2015-08-06 18:02                 ` Scott Wood
2015-08-07  3:19                   ` Chenhui Zhao
2015-08-08  0:13                     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438771186.21522.1@remotesmtp.freescale.net \
    --to=chenhui.zhao@freescale.com \
    --cc=Yuantian.Tang@freescale.com \
    --cc=b07421@freescale.com \
    --cc=b29983@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®