From: David Woodhouse <dwmw2@infradead.org>
To: James Morris <jmorris@namei.org>
Cc: David Howells <dhowells@redhat.com>,
mcgrof@gmail.com, Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [GIT PULL] MODSIGN: Use PKCS#7 for module signatures [ver #7a]
Date: Wed, 12 Aug 2015 11:59:33 +0100 [thread overview]
Message-ID: <1439377173.3100.73.camel@infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.20.1508122040081.17160@namei.org>
[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]
On Wed, 2015-08-12 at 20:40 +1000, James Morris wrote:
>
> This works for me:
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 9e31922..65ef384 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -150,7 +150,7 @@ space :=
> space +=
> space_escape := %%%SPACE%%%
> #
> -define config_filename =
> +define config_filename
> ifneq ($$(CONFIG_$(1)),"")
> $(1)_FILENAME := $$(subst \\,\,$$(subst \$$(quote),$$(quote),$$(subst $$(space_escape),\$$(space),$$(patsubst "%",%,$$(subst $$(space),$$(space_escape),$$(CONFIG_$(1)))))))
> ifneq ($$(patsubst /%,%,$$(firstword $$($(1)_FILENAME))),$$(firstword $$($(1)_FILENAME)))
>
Thanks. I believe David is travelling and in GMT-4 at the moment; I
imagine he'll want to roll up this one-line fix into the offending
original commit, and submit a new pull request.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]
next prev parent reply other threads:[~2015-08-12 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 20:03 David Howells
2015-08-12 4:20 ` James Morris
2015-08-12 7:07 ` David Woodhouse
2015-08-12 9:08 ` James Morris
2015-08-12 9:12 ` David Woodhouse
2015-08-12 9:27 ` James Morris
2015-08-12 9:50 ` David Woodhouse
2015-08-12 10:08 ` James Morris
2015-08-12 10:23 ` David Woodhouse
2015-08-12 10:30 ` James Morris
2015-08-12 10:40 ` James Morris
2015-08-12 10:59 ` David Woodhouse [this message]
2015-08-12 15:51 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439377173.3100.73.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®