From: James Morris <jmorris@namei.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
mcgrof@gmail.com, Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [GIT PULL] MODSIGN: Use PKCS#7 for module signatures [ver #7a]
Date: Wed, 12 Aug 2015 20:30:10 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.20.1508122029080.17160@namei.org> (raw)
In-Reply-To: <1439375000.3100.70.camel@infradead.org>
On Wed, 12 Aug 2015, David Woodhouse wrote:
> On Wed, 2015-08-12 at 20:08 +1000, James Morris wrote:
> > make-3.81-20.el6.x86_64
> >
> > The machine is not accessible, sorry.
>
> No matter. I have a CentOS 6 VM in which I can attempt to reproduce.
>
> > Where is MODULE_SIG_KEY_FILENAME assigned?
>
> At about line 243:
>
> $(eval $(call config_filename,MODULE_SIG_KEY))
>
> Or, more to the point, somewhere in here... you may now understand why
> I made a new jug of coffee. I had torture-tested this with fairly much
> every pathology I could think of. And you've managed to break it with
> the *default* case. Congratulations. You just made me cry.
You made me read Make documentation -- I think we're even.
> #
> define config_filename =
This may be relevant:
http://stackoverflow.com/questions/13260396/gnu-make-3-81-eval-function-not-working
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2015-08-12 10:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 20:03 David Howells
2015-08-12 4:20 ` James Morris
2015-08-12 7:07 ` David Woodhouse
2015-08-12 9:08 ` James Morris
2015-08-12 9:12 ` David Woodhouse
2015-08-12 9:27 ` James Morris
2015-08-12 9:50 ` David Woodhouse
2015-08-12 10:08 ` James Morris
2015-08-12 10:23 ` David Woodhouse
2015-08-12 10:30 ` James Morris [this message]
2015-08-12 10:40 ` James Morris
2015-08-12 10:59 ` David Woodhouse
2015-08-12 15:51 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1508122029080.17160@namei.org \
--to=jmorris@namei.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®