From: Toshi Kani <toshi.kani@hp.com>
To: dan.j.williams@intel.com
Cc: ross.zwisler@linux.intel.com, linux-nvdimm@ml01.01.org,
linux-kernel@vger.kernel.org, Toshi Kani <toshi.kani@hp.com>
Subject: [PATCH] nfit: Fix undefined mmio_flush_range on x86_32
Date: Fri, 28 Aug 2015 19:18:44 -0600 [thread overview]
Message-ID: <1440811124-1634-1-git-send-email-toshi.kani@hp.com> (raw)
The following compile error was observed on x86_32 since nfit.c
relies on <asm/pmem.h> to include <asm/cacheflush.h>, which only
works when CONFIG_ARCH_HAS_PMEM_API is set on x86_64.
drivers/acpi/nfit.c:1085:5: error: implicit declaration of
function 'mmio_flush_range' [-Werror=implicit-function-declaration]
Change nfit.c to include <asm/cacheflush.h> directly for now.
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
---
Apply on top of libnvdimm-for-next of the nvdimm tree.
This is a temporary fix and please feel free to replace it with
a better solution.
---
drivers/acpi/nfit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index 82d07e8..f61e69f 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -20,6 +20,7 @@
#include <linux/sort.h>
#include <linux/pmem.h>
#include <linux/io.h>
+#include <asm/cacheflush.h>
#include "nfit.h"
/*
next reply other threads:[~2015-08-29 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 1:18 Toshi Kani [this message]
2015-08-29 3:31 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440811124-1634-1-git-send-email-toshi.kani@hp.com \
--to=toshi.kani@hp.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®