* [PATCH] nfit: Fix undefined mmio_flush_range on x86_32
@ 2015-08-29 1:18 Toshi Kani
2015-08-29 3:31 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Toshi Kani @ 2015-08-29 1:18 UTC (permalink / raw)
To: dan.j.williams; +Cc: ross.zwisler, linux-nvdimm, linux-kernel, Toshi Kani
The following compile error was observed on x86_32 since nfit.c
relies on <asm/pmem.h> to include <asm/cacheflush.h>, which only
works when CONFIG_ARCH_HAS_PMEM_API is set on x86_64.
drivers/acpi/nfit.c:1085:5: error: implicit declaration of
function 'mmio_flush_range' [-Werror=implicit-function-declaration]
Change nfit.c to include <asm/cacheflush.h> directly for now.
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
---
Apply on top of libnvdimm-for-next of the nvdimm tree.
This is a temporary fix and please feel free to replace it with
a better solution.
---
drivers/acpi/nfit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index 82d07e8..f61e69f 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -20,6 +20,7 @@
#include <linux/sort.h>
#include <linux/pmem.h>
#include <linux/io.h>
+#include <asm/cacheflush.h>
#include "nfit.h"
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nfit: Fix undefined mmio_flush_range on x86_32
2015-08-29 1:18 [PATCH] nfit: Fix undefined mmio_flush_range on x86_32 Toshi Kani
@ 2015-08-29 3:31 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2015-08-29 3:31 UTC (permalink / raw)
To: Toshi Kani; +Cc: Ross Zwisler, linux-nvdimm@lists.01.org, linux-kernel
On Fri, Aug 28, 2015 at 6:18 PM, Toshi Kani <toshi.kani@hp.com> wrote:
> The following compile error was observed on x86_32 since nfit.c
> relies on <asm/pmem.h> to include <asm/cacheflush.h>, which only
> works when CONFIG_ARCH_HAS_PMEM_API is set on x86_64.
>
> drivers/acpi/nfit.c:1085:5: error: implicit declaration of
> function 'mmio_flush_range' [-Werror=implicit-function-declaration]
>
> Change nfit.c to include <asm/cacheflush.h> directly for now.
>
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> Apply on top of libnvdimm-for-next of the nvdimm tree.
> This is a temporary fix and please feel free to replace it with
> a better solution.
This looks correct to me, I'm going to fold it in to where the breakage occurs.
Thanks Toshi!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-29 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-29 1:18 [PATCH] nfit: Fix undefined mmio_flush_range on x86_32 Toshi Kani
2015-08-29 3:31 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®