From: Arnd Bergmann <arnd@arndb.de>
To: Laura Abbott <labbott@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls
Date: Sat, 03 Sep 2016 00:44:02 +0200 [thread overview]
Message-ID: <14410979.OgeTP9zliP@wuerfel> (raw)
In-Reply-To: <1472856144-4659-1-git-send-email-labbott@redhat.com>
On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote:
> - The guide currently says to pad the structure to a multiple of
> 64-bits. This is not necessary in cases where the structure contains
> no 64-bit types. Clarify this concept to avoid unnecessary padding.
> - When using __u64 to hold user pointers, blindly trying to do a cast to
> a void __user * may generate a warning on 32-bit systems about a cast
> from an integer to a pointer of different size. There is a macro to
> deal with this which hides an ugly double cast. Add a reference to
> this macro.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
>
Looks good to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-09-02 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 22:42 Laura Abbott
2016-09-02 22:44 ` Arnd Bergmann [this message]
2016-09-06 12:00 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14410979.OgeTP9zliP@wuerfel \
--to=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=labbott@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome