* [PATCH] Makefile: .PHONY is not a variable, but PHONY is
@ 2015-09-02 13:11 ulfalizer.lkml
2017-12-07 15:03 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: ulfalizer.lkml @ 2015-09-02 13:11 UTC (permalink / raw)
To: linux-kbuild; +Cc: linux-kernel, ulfalizer, mmarek, trivial
From: Ulf Magnusson <ulfalizer@gmail.com>
.PHONY is a target, not a variable.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 24c9e3d..4835d24 100644
--- a/Makefile
+++ b/Makefile
@@ -1609,6 +1609,6 @@ endif # skip-makefile
PHONY += FORCE
FORCE:
-# Declare the contents of the .PHONY variable as phony. We keep that
+# Declare the contents of the PHONY variable as phony. We keep that
# information in a variable so we can use it in if_changed and friends.
.PHONY: $(PHONY)
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile: .PHONY is not a variable, but PHONY is
2015-09-02 13:11 [PATCH] Makefile: .PHONY is not a variable, but PHONY is ulfalizer.lkml
@ 2017-12-07 15:03 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2017-12-07 15:03 UTC (permalink / raw)
To: ulfalizer.lkml, Ulf Magnusson
Cc: Linux Kbuild mailing list, Linux Kernel Mailing List, Jiri Kosina
Hi Ulf,
2015-09-02 22:11 GMT+09:00 <ulfalizer.lkml@gmail.com>:
> From: Ulf Magnusson <ulfalizer@gmail.com>
>
> .PHONY is a target, not a variable.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 24c9e3d..4835d24 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1609,6 +1609,6 @@ endif # skip-makefile
> PHONY += FORCE
> FORCE:
>
> -# Declare the contents of the .PHONY variable as phony. We keep that
> +# Declare the contents of the PHONY variable as phony. We keep that
> # information in a variable so we can use it in if_changed and friends.
> .PHONY: $(PHONY)
> --
I found this patch by chance.
Can you fix other files in scripts/ as well?
I see the same pattern in
Makefile.build
Makefile.clean
Makefile.modbuiltin
Makefile.modinst
Makefile.modpost
Makefile.modsign
Then, I will apply it quickly.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-07 15:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-02 13:11 [PATCH] Makefile: .PHONY is not a variable, but PHONY is ulfalizer.lkml
2017-12-07 15:03 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®