From: kan.liang@intel.com
To: acme@kernel.org, jolsa@kernel.org
Cc: a.p.zijlstra@chello.nl, luto@kernel.org, mingo@redhat.com,
eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
adrian.hunter@intel.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, Kan Liang <kan.liang@intel.com>
Subject: [PATCH V8 4/7] perf,tools: fix dump_sample crash when evsel is NULL.
Date: Thu, 3 Sep 2015 08:31:00 -0400 [thread overview]
Message-ID: <1441283463-51050-5-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1441283463-51050-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
Need to check evsel before using in dump_sample.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
tools/perf/util/session.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 61669be..23fed17 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1080,11 +1080,11 @@ static int machines__deliver_event(struct machines *machines,
switch (event->header.type) {
case PERF_RECORD_SAMPLE:
- dump_sample(evsel, event, sample);
if (evsel == NULL) {
++evlist->stats.nr_unknown_id;
return 0;
}
+ dump_sample(evsel, event, sample);
if (machine == NULL) {
++evlist->stats.nr_unprocessable_samples;
return 0;
--
1.8.3.1
next prev parent reply other threads:[~2015-09-03 19:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 12:30 [PATCH V8 0/7] Freq/CPU%/CORE_BUSY% support kan.liang
2015-09-03 12:30 ` [PATCH V8 1/7] perf,tools: introduce generic FEAT for CPU attributes kan.liang
2015-09-03 12:30 ` [PATCH V8 2/7] perf,tools: read msr pmu type from header kan.liang
2015-09-03 12:30 ` [PATCH V8 3/7] perf, record: introduce --freq-perf option kan.liang
2015-09-07 10:57 ` Jiri Olsa
2015-09-08 15:21 ` Liang, Kan
2015-09-03 12:31 ` kan.liang [this message]
2015-09-08 14:38 ` [tip:perf/core] perf session: Don't call dump_sample() when evsel is NULL tip-bot for Kan Liang
2015-09-03 12:31 ` [PATCH V8 5/7] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D kan.liang
2015-09-03 12:31 ` [PATCH V8 6/7] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat kan.liang
2015-09-03 12:31 ` [PATCH V8 7/7] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio kan.liang
2015-09-07 11:17 ` Jiri Olsa
2015-09-07 11:36 ` [PATCH V8 0/7] Freq/CPU%/CORE_BUSY% support Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441283463-51050-5-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®