From: tip-bot for Kan Liang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, jolsa@kernel.org, luto@kernel.org,
adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, mingo@kernel.org, a.p.zijlstra@chello.nl,
eranian@google.com, ak@linux.intel.com, hpa@zytor.com,
kan.liang@intel.com, tglx@linutronix.de, namhyung@kernel.org
Subject: [tip:perf/core] perf session: Don't call dump_sample() when evsel is NULL
Date: Tue, 8 Sep 2015 07:38:25 -0700 [thread overview]
Message-ID: <tip-1b29ac59b1d692c06ec543a5f35e0d9ebb98e003@git.kernel.org> (raw)
In-Reply-To: <1441283463-51050-5-git-send-email-kan.liang@intel.com>
Commit-ID: 1b29ac59b1d692c06ec543a5f35e0d9ebb98e003
Gitweb: http://git.kernel.org/tip/1b29ac59b1d692c06ec543a5f35e0d9ebb98e003
Author: Kan Liang <kan.liang@intel.com>
AuthorDate: Thu, 3 Sep 2015 08:31:00 -0400
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 4 Sep 2015 12:01:04 -0300
perf session: Don't call dump_sample() when evsel is NULL
Need to check evsel before passing it to dump_sample().
Signed-off-by: Kan Liang <kan.liang@intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1441283463-51050-5-git-send-email-kan.liang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/session.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 61669be..23fed17 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1080,11 +1080,11 @@ static int machines__deliver_event(struct machines *machines,
switch (event->header.type) {
case PERF_RECORD_SAMPLE:
- dump_sample(evsel, event, sample);
if (evsel == NULL) {
++evlist->stats.nr_unknown_id;
return 0;
}
+ dump_sample(evsel, event, sample);
if (machine == NULL) {
++evlist->stats.nr_unprocessable_samples;
return 0;
next prev parent reply other threads:[~2015-09-08 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 12:30 [PATCH V8 0/7] Freq/CPU%/CORE_BUSY% support kan.liang
2015-09-03 12:30 ` [PATCH V8 1/7] perf,tools: introduce generic FEAT for CPU attributes kan.liang
2015-09-03 12:30 ` [PATCH V8 2/7] perf,tools: read msr pmu type from header kan.liang
2015-09-03 12:30 ` [PATCH V8 3/7] perf, record: introduce --freq-perf option kan.liang
2015-09-07 10:57 ` Jiri Olsa
2015-09-08 15:21 ` Liang, Kan
2015-09-03 12:31 ` [PATCH V8 4/7] perf,tools: fix dump_sample crash when evsel is NULL kan.liang
2015-09-08 14:38 ` tip-bot for Kan Liang [this message]
2015-09-03 12:31 ` [PATCH V8 5/7] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D kan.liang
2015-09-03 12:31 ` [PATCH V8 6/7] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat kan.liang
2015-09-03 12:31 ` [PATCH V8 7/7] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio kan.liang
2015-09-07 11:17 ` Jiri Olsa
2015-09-07 11:36 ` [PATCH V8 0/7] Freq/CPU%/CORE_BUSY% support Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-1b29ac59b1d692c06ec543a5f35e0d9ebb98e003@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome