[PATCH 00/01] kdbus: Eliminate warning caused by lack of uapi/linux/kdbus.h inclusion

[PATCH 00/01] kdbus: Eliminate warning caused by lack of uapi/linux/kdbus.h inclusion

[Paul Osmialowski]

This is the patch that fixes problem with compiler warning message caused
by lack of header inclusion.

The problem does not occur during normal kernel build. It was uncovered
during my recent works on LSM hooks for KDBUS.

Without this patch my yet to be released patches produce warning message
during compilation.

Paul Osmialowski (1):
  kdbus: Eliminate warning caused by lack of uapi/linux/kdbus.h
    inclusion

 ipc/kdbus/metadata.h | 1 +
 1 file changed, 1 insertion(+)

-- 
1.9.1

[PATCH 01/01] kdbus: Eliminate warning caused by lack of uapi/linux/kdbus.h inclusion

[Paul Osmialowski]

metadata.h references struct kdbus_pids which is defined in
uapi/linux/kdbus.h

Normally, kdbus/metadata.h is included after many other headers
that eventually include uapi/linux/kdbus.h at some point (e.g. kdbus/bus.h
includes uapi/linux/kdbus.h), this prevents the warning.

When included alone, it causes warning. Also when kdbus/connection.h
is included alone, the same warning is shown since kdbus/connection.h
includes kdbus/metadata.h.

This patch adds missing inclusion.

Signed-off-by: Paul Osmialowski <p.osmialowsk@samsung.com>
---
 ipc/kdbus/metadata.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ipc/kdbus/metadata.h b/ipc/kdbus/metadata.h
index dba7cc7..3f9ba38 100644
--- a/ipc/kdbus/metadata.h
+++ b/ipc/kdbus/metadata.h
@@ -16,6 +16,7 @@
 #define __KDBUS_METADATA_H
 
 #include <linux/kernel.h>
+#include <uapi/linux/kdbus.h>
 
 struct kdbus_conn;
 struct kdbus_pool_slice;
-- 
1.9.1

Re: [PATCH 01/01] kdbus: Eliminate warning caused by lack of uapi/linux/kdbus.h inclusion

[David Herrmann]

Hi

On Tue, Sep 8, 2015 at 2:48 PM, Paul Osmialowski
<p.osmialowsk@samsung.com> wrote:
> metadata.h references struct kdbus_pids which is defined in
> uapi/linux/kdbus.h
>
> Normally, kdbus/metadata.h is included after many other headers
> that eventually include uapi/linux/kdbus.h at some point (e.g. kdbus/bus.h
> includes uapi/linux/kdbus.h), this prevents the warning.
>
> When included alone, it causes warning. Also when kdbus/connection.h
> is included alone, the same warning is shown since kdbus/connection.h
> includes kdbus/metadata.h.
>
> This patch adds missing inclusion.
>
> Signed-off-by: Paul Osmialowski <p.osmialowsk@samsung.com>
> ---
>  ipc/kdbus/metadata.h | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> diff --git a/ipc/kdbus/metadata.h b/ipc/kdbus/metadata.h
> index dba7cc7..3f9ba38 100644
> --- a/ipc/kdbus/metadata.h
> +++ b/ipc/kdbus/metadata.h
> @@ -16,6 +16,7 @@
>  #define __KDBUS_METADATA_H
>
>  #include <linux/kernel.h>
> +#include <uapi/linux/kdbus.h>
>
>  struct kdbus_conn;
>  struct kdbus_pool_slice;
> --
> 1.9.1
>