mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	Pranith Kumar <bobby.prani@gmail.com>,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v3] Cleanup: membarrier selftest
Date: Wed, 09 Sep 2015 18:36:44 +1000	[thread overview]
Message-ID: <1441787804.4703.2.camel@ellerman.id.au> (raw)
In-Reply-To: <1441745890-25852-1-git-send-email-mathieu.desnoyers@efficios.com>

On Tue, 2015-09-08 at 16:58 -0400, Mathieu Desnoyers wrote:
> We don't need to specify an explicit rule in the Makefile, the implicit
> one will do the same. The "__EXPORTED_HEADERS__" define is not needed,
> because we build the test against the installed kernel headers, not the
> in-tree kernel headers. Re-use "$(TEST_PROGS)" in the clean target
> rather than spelling the executable name twice. Include <unistd.h>
> rather than the rather specific <asm-generic/unistd.h>. Include
> <syscall.h> rather than <sys/syscall.h>. In both cases, the former
> header is located in a standard location and includes the latter.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Michael Ellerman <mpe@ellerman.id.au>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: linux-api@vger.kernel.org
> CC: Pranith Kumar <bobby.prani@gmail.com>
> CC: Shuah Khan <shuahkh@osg.samsung.com>
> --
> Changes since v2:
> - Refine Changelog, removing references to comments, taking care
>   of comments from Shuah Khan.
> Changes since v1:
> - Add Changelog.
> Changes since RFC:
> - Take care of comments from Michael Ellerman.

Looks great, thanks.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers



      reply	other threads:[~2015-09-09  8:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08 20:58 Mathieu Desnoyers
2015-09-09  8:36 ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441787804.4703.2.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=akpm@linux-foundation.org \
    --cc=bobby.prani@gmail.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®