* [PATCH] fix incorrect initialization code for trans_stat of devfreq
@ 2015-09-11 3:05 Xiaolong Ye
2015-09-11 3:05 ` [PATCH] PM / devfreq: Fix incorrect type issue Xiaolong Ye
0 siblings, 1 reply; 2+ messages in thread
From: Xiaolong Ye @ 2015-09-11 3:05 UTC (permalink / raw)
To: myungjoo.ham, kyungmin.park, linux-pm, linux-kernel, yizhang, kliu5
Cc: Xiaolong Ye
Hi,
I met trans_stat abnormal issue while debugging devfreq feature for ddr in arm64 system, cat trans_stat
would get extremely large time value which is unreasonable, I checked the code and found it was caused by
incorrect initialization code, time_in_state is initialized by devm_kzalloc and wrongly use sizeof(unsigned int)
as argument, but time_in_state which is defined in struct devfreq actually is defined as unsigned long, so
it is ok for 32 bit system, but will cause unexpected result in 64 bit system.
Xiaolong Ye (1):
PM / devfreq: Fix incorrect type issue.
drivers/devfreq/devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] PM / devfreq: Fix incorrect type issue.
2015-09-11 3:05 [PATCH] fix incorrect initialization code for trans_stat of devfreq Xiaolong Ye
@ 2015-09-11 3:05 ` Xiaolong Ye
0 siblings, 0 replies; 2+ messages in thread
From: Xiaolong Ye @ 2015-09-11 3:05 UTC (permalink / raw)
To: myungjoo.ham, kyungmin.park, linux-pm, linux-kernel, yizhang, kliu5
Cc: Xiaolong Ye
time_in_state in struct devfreq is defined as unsigned long, so
devm_kzalloc should use sizeof(unsigned long) as argument instead
of sizeof(unsigned int), otherwise it will cause unexpected result
in 64bit system.
Signed-off-by: Xiaolong Ye <yexl@marvell.com>
Signed-off-by: Kevin Liu <kliu5@marvell.com>
---
drivers/devfreq/devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index ca1b362..ac9845a 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -482,7 +482,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
devfreq->profile->max_state *
devfreq->profile->max_state,
GFP_KERNEL);
- devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned int) *
+ devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned long) *
devfreq->profile->max_state,
GFP_KERNEL);
devfreq->last_stat_updated = jiffies;
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-11 3:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-11 3:05 [PATCH] fix incorrect initialization code for trans_stat of devfreq Xiaolong Ye
2015-09-11 3:05 ` [PATCH] PM / devfreq: Fix incorrect type issue Xiaolong Ye
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®