* [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison
@ 2015-09-11 5:10 Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 06/16] Staging: rtl8188eu: " Shraddha Barke
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: Shraddha Barke @ 2015-09-11 5:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sudip Mukherjee, Andrzej Pietrasiewicz, Julia Lawall
Cc: linux-kernel, Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Changes in v2-
No change
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index b340e4a..497fb06 100644
--- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
@@ -273,7 +273,7 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta)
struct sta_priv *pstapriv = &padapter->stapriv;
- if (psta == NULL)
+ if (!psta)
goto exit;
pfree_sta_queue = &pstapriv->free_sta_queue;
@@ -433,7 +433,7 @@ struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, u8 *hwaddr)
u8 bc_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
- if (hwaddr == NULL)
+ if (!hwaddr)
return NULL;
if (IS_MCAST(hwaddr))
@@ -473,7 +473,7 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter)
psta = rtw_alloc_stainfo(pstapriv, bcast_addr);
- if (psta == NULL) {
+ if (!psta) {
res = _FAIL;
RT_TRACE(_module_rtl871x_sta_mgt_c_, _drv_err_, ("rtw_alloc_stainfo fail"));
goto exit;
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 06/16] Staging: rtl8188eu: Remove explicit NULL comparison
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
@ 2015-09-11 5:10 ` Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 11/16] Staging: rtl8188eu: hal: " Shraddha Barke
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Shraddha Barke @ 2015-09-11 5:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sudip Mukherjee, Andrzej Pietrasiewicz, Julia Lawall
Cc: linux-kernel, Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Change in v2-
No change.
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
index 0a62bfa..d528140 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
@@ -467,7 +467,7 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished)
DBG_88E("%s\n", __func__);
ReservedPagePacket = kzalloc(1000, GFP_KERNEL);
- if (ReservedPagePacket == NULL) {
+ if (!ReservedPagePacket) {
DBG_88E("%s: alloc ReservedPagePacket fail!\n", __func__);
return;
}
@@ -537,7 +537,7 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished)
TotalPacketLen = BufIndex + QosNullLength;
pmgntframe = alloc_mgtxmitframe(pxmitpriv);
- if (pmgntframe == NULL)
+ if (!pmgntframe)
goto exit;
/* update attribute */
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 11/16] Staging: rtl8188eu: hal: Remove explicit NULL comparison
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 06/16] Staging: rtl8188eu: " Shraddha Barke
@ 2015-09-11 5:10 ` Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 12/16] Staging: rtl8188eu: hal: Hal8188ERateAdaptive.c: " Shraddha Barke
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Shraddha Barke @ 2015-09-11 5:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sudip Mukherjee, Andrzej Pietrasiewicz, Julia Lawall
Cc: linux-kernel, Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Change in v2-
No change
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 06d1e65..d6d009a 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -43,7 +43,7 @@ int rtl8188eu_init_recv_priv(struct adapter *padapter)
precvpriv->pallocated_recv_buf =
kcalloc(NR_RECVBUFF, sizeof(struct recv_buf), GFP_KERNEL);
- if (precvpriv->pallocated_recv_buf == NULL) {
+ if (!precvpriv->pallocated_recv_buf) {
res = _FAIL;
RT_TRACE(_module_rtl871x_recv_c_, _drv_err_,
("alloc recv_buf fail!\n"));
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 12/16] Staging: rtl8188eu: hal: Hal8188ERateAdaptive.c: Remove explicit NULL comparison
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 06/16] Staging: rtl8188eu: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 11/16] Staging: rtl8188eu: hal: " Shraddha Barke
@ 2015-09-11 5:10 ` Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 13/16] Staging: rtl8188eu: hal: rtl8188eu_xmit.c: " Shraddha Barke
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Shraddha Barke @ 2015-09-11 5:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sudip Mukherjee, Andrzej Pietrasiewicz, Julia Lawall
Cc: linux-kernel, Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Change in v2-
No change
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
index 2633a13..a108e80 100644
--- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
+++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
@@ -127,7 +127,7 @@ static int odm_RateDown_8188E(struct odm_dm_struct *dm_odm,
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
ODM_DBG_TRACE, ("=====>odm_RateDown_8188E()\n"));
- if (NULL == pRaInfo) {
+ if (!pRaInfo) {
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
("odm_RateDown_8188E(): pRaInfo is NULL\n"));
return -1;
@@ -193,7 +193,7 @@ static int odm_RateUp_8188E(
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
ODM_DBG_TRACE, ("=====>odm_RateUp_8188E()\n"));
- if (NULL == pRaInfo) {
+ if (!pRaInfo) {
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
("odm_RateUp_8188E(): pRaInfo is NULL\n"));
return -1;
@@ -624,7 +624,7 @@ int ODM_RAInfo_Init_all(struct odm_dm_struct *dm_odm)
u8 ODM_RA_GetShortGI_8188E(struct odm_dm_struct *dm_odm, u8 macid)
{
- if ((NULL == dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
+ if ((!dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
return 0;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_TRACE,
("macid =%d SGI =%d\n", macid, dm_odm->RAInfo[macid].RateSGI));
@@ -635,7 +635,7 @@ u8 ODM_RA_GetDecisionRate_8188E(struct odm_dm_struct *dm_odm, u8 macid)
{
u8 DecisionRate = 0;
- if ((NULL == dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
+ if ((!dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
return 0;
DecisionRate = dm_odm->RAInfo[macid].DecisionRate;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_TRACE,
@@ -647,7 +647,7 @@ u8 ODM_RA_GetHwPwrStatus_8188E(struct odm_dm_struct *dm_odm, u8 macid)
{
u8 PTStage = 5;
- if ((NULL == dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
+ if ((!dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
return 0;
PTStage = dm_odm->RAInfo[macid].PTStage;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_TRACE,
@@ -659,7 +659,7 @@ void ODM_RA_UpdateRateInfo_8188E(struct odm_dm_struct *dm_odm, u8 macid, u8 Rate
{
struct odm_ra_info *pRaInfo = NULL;
- if ((NULL == dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
+ if ((!dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
return;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
("macid =%d RateID = 0x%x RateMask = 0x%x SGIEnable =%d\n",
@@ -676,7 +676,7 @@ void ODM_RA_SetRSSI_8188E(struct odm_dm_struct *dm_odm, u8 macid, u8 Rssi)
{
struct odm_ra_info *pRaInfo = NULL;
- if ((NULL == dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
+ if ((!dm_odm) || (macid >= ASSOCIATE_ENTRY_NUM))
return;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_TRACE,
(" macid =%d Rssi =%d\n", macid, Rssi));
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 13/16] Staging: rtl8188eu: hal: rtl8188eu_xmit.c: Remove explicit NULL comparison
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
` (2 preceding siblings ...)
2015-09-11 5:10 ` [PATCH v2 12/16] Staging: rtl8188eu: hal: Hal8188ERateAdaptive.c: " Shraddha Barke
@ 2015-09-11 5:10 ` Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 14/16] Staging: rtl8188eu: os_dep: recv_linux.c: " Shraddha Barke
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Shraddha Barke @ 2015-09-11 5:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sudip Mukherjee, Andrzej Pietrasiewicz, Julia Lawall
Cc: linux-kernel, Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Changes in v2-
No change
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
index 594c1da..4433560 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
@@ -649,7 +649,7 @@ static s32 pre_xmitframe(struct adapter *adapt, struct xmit_frame *pxmitframe)
goto enqueue;
pxmitbuf = rtw_alloc_xmitbuf(pxmitpriv);
- if (pxmitbuf == NULL)
+ if (!pxmitbuf)
goto enqueue;
spin_unlock_bh(&pxmitpriv->lock);
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 14/16] Staging: rtl8188eu: os_dep: recv_linux.c: Remove explicit NULL comparison
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
` (3 preceding siblings ...)
2015-09-11 5:10 ` [PATCH v2 13/16] Staging: rtl8188eu: hal: rtl8188eu_xmit.c: " Shraddha Barke
@ 2015-09-11 5:10 ` Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 15/16] Staging: rtl8188eu: os_dep: mlme_linux.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 16/16] Staging: rtl8188eu: os_dep: osdep_service.c: " Shraddha Barke
6 siblings, 0 replies; 8+ messages in thread
From: Shraddha Barke @ 2015-09-11 5:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sudip Mukherjee, Andrzej Pietrasiewicz, Julia Lawall
Cc: linux-kernel, Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Change in v2-
No change
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 3ebb8b2..d4734baf 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -94,7 +94,7 @@ int rtw_recv_indicatepkt(struct adapter *padapter,
pfree_recv_queue = &(precvpriv->free_recv_queue);
skb = precv_frame->pkt;
- if (skb == NULL) {
+ if (!skb) {
RT_TRACE(_module_recv_osdep_c_, _drv_err_,
("rtw_recv_indicatepkt():skb == NULL something wrong!!!!\n"));
goto _recv_indicatepkt_drop;
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 15/16] Staging: rtl8188eu: os_dep: mlme_linux.c: Remove explicit NULL comparison
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
` (4 preceding siblings ...)
2015-09-11 5:10 ` [PATCH v2 14/16] Staging: rtl8188eu: os_dep: recv_linux.c: " Shraddha Barke
@ 2015-09-11 5:10 ` Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 16/16] Staging: rtl8188eu: os_dep: osdep_service.c: " Shraddha Barke
6 siblings, 0 replies; 8+ messages in thread
From: Shraddha Barke @ 2015-09-11 5:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sudip Mukherjee, Andrzej Pietrasiewicz, Julia Lawall
Cc: linux-kernel, Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Change in v2-
No changes
drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c b/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
index 218adaa..eb8ecb7 100644
--- a/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/mlme_linux.c
@@ -152,7 +152,7 @@ void rtw_indicate_sta_assoc_event(struct adapter *padapter, struct sta_info *pst
union iwreq_data wrqu;
struct sta_priv *pstapriv = &padapter->stapriv;
- if (psta == NULL)
+ if (!psta)
return;
if (psta->aid > NUM_STA)
@@ -176,7 +176,7 @@ void rtw_indicate_sta_disassoc_event(struct adapter *padapter, struct sta_info *
union iwreq_data wrqu;
struct sta_priv *pstapriv = &padapter->stapriv;
- if (psta == NULL)
+ if (!psta)
return;
if (psta->aid > NUM_STA)
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 16/16] Staging: rtl8188eu: os_dep: osdep_service.c: Remove explicit NULL comparison
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
` (5 preceding siblings ...)
2015-09-11 5:10 ` [PATCH v2 15/16] Staging: rtl8188eu: os_dep: mlme_linux.c: " Shraddha Barke
@ 2015-09-11 5:10 ` Shraddha Barke
6 siblings, 0 replies; 8+ messages in thread
From: Shraddha Barke @ 2015-09-11 5:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sudip Mukherjee, Andrzej Pietrasiewicz, Julia Lawall
Cc: linux-kernel, Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Change in v2-
No change
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c b/drivers/staging/rtl8188eu/os_dep/osdep_service.c
index acb4eb1..466cd76 100644
--- a/drivers/staging/rtl8188eu/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8188eu/os_dep/osdep_service.c
@@ -52,7 +52,7 @@ void *rtw_malloc2d(int h, int w, int size)
int j;
void **a = kzalloc(h*sizeof(void *) + h*w*size, GFP_KERNEL);
- if (a == NULL) {
+ if (!a) {
pr_info("%s: alloc memory fail!\n", __func__);
return NULL;
}
--
2.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-09-11 5:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-11 5:10 [PATCH v2 05/16] Staging: rtl8188eu: core: Remove explicit NULL comparison Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 06/16] Staging: rtl8188eu: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 11/16] Staging: rtl8188eu: hal: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 12/16] Staging: rtl8188eu: hal: Hal8188ERateAdaptive.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 13/16] Staging: rtl8188eu: hal: rtl8188eu_xmit.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 14/16] Staging: rtl8188eu: os_dep: recv_linux.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 15/16] Staging: rtl8188eu: os_dep: mlme_linux.c: " Shraddha Barke
2015-09-11 5:10 ` [PATCH v2 16/16] Staging: rtl8188eu: os_dep: osdep_service.c: " Shraddha Barke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®