From: Philipp Zabel <p.zabel@pengutronix.de>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, xuwei5@hisilicon.com,
haojian.zhuang@linaro.org, zhangfei.gao@foxmail.com,
arnd@arndb.de, bintian.wang@huawei.com, xuyiping@hisilicon.com,
devicetree@vger.kernel.org, dan.zhao@hisilicon.com,
suzhuangluan@hisilicon.com, w.f@huawei.com
Subject: Re: [PATCH V3 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC
Date: Tue, 15 Sep 2015 11:10:54 +0200 [thread overview]
Message-ID: <1442308254.3979.31.camel@pengutronix.de> (raw)
In-Reply-To: <1442289504-183550-1-git-send-email-puck.chen@hisilicon.com>
Am Dienstag, den 15.09.2015, 11:58 +0800 schrieb Chen Feng:
> Add reset controller for hi6220 hikey-board.
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 3f03380..3bbc846 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -167,5 +167,12 @@
> clocks = <&ao_ctrl 36>, <&ao_ctrl 36>;
> clock-names = "uartclk", "apb_pclk";
> };
> +
> + reset_ctrl: reset_ctrl@f7030000 {
> + compatible = "hisilicon,hi6220_reset_ctl";
Check out the other compatible strings that already are in the same dtsi
file, those use hyphens instead of underscores in their compatible
values. So for consistency, this should be:
+ compatible = "hisilicon,hi6220-reset-ctl";
regards
Philipp
prev parent reply other threads:[~2015-09-15 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 3:58 Chen Feng
2015-09-15 3:58 ` [PATCH V3 2/3] reset: hisilicon: document hisi-hi6220 reset controllers bindings Chen Feng
2015-09-15 9:11 ` Philipp Zabel
2015-09-15 3:58 ` [PATCH V3 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC Chen Feng
2015-09-15 7:10 ` xuyiping
2015-09-15 9:11 ` Philipp Zabel
2015-09-15 9:10 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442308254.3979.31.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=arnd@arndb.de \
--cc=bintian.wang@huawei.com \
--cc=dan.zhao@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=haojian.zhuang@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=puck.chen@hisilicon.com \
--cc=robh+dt@kernel.org \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=zhangfei.gao@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®