From: Robert Baldyga <r.baldyga@samsung.com>
To: gregkh@linuxfoundation.org
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
k.kozlowski@samsung.com, Robert Baldyga <r.baldyga@samsung.com>
Subject: [PATCH v3 2/4] serial: samsung: remove unneded 'ignore_char' label
Date: Tue, 15 Sep 2015 14:48:58 +0200 [thread overview]
Message-ID: <1442321340-28167-3-git-send-email-r.baldyga@samsung.com> (raw)
In-Reply-To: <1442321340-28167-1-git-send-email-r.baldyga@samsung.com>
This label does nothing special and we don't need to have it anymore.
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/tty/serial/samsung.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index fee764c..dc4be54 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -676,7 +676,7 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id)
dbg("break!\n");
port->icount.brk++;
if (uart_handle_break(port))
- goto ignore_char;
+ continue; /* Ignore character */
}
if (uerstat & S3C2410_UERSTAT_FRAME)
@@ -696,13 +696,10 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id)
}
if (uart_handle_sysrq_char(port, ch))
- goto ignore_char;
+ continue; /* Ignore character */
uart_insert_char(port, uerstat, S3C2410_UERSTAT_OVERRUN,
ch, flag);
-
-ignore_char:
- continue;
}
spin_unlock_irqrestore(&port->lock, flags);
--
1.9.1
next prev parent reply other threads:[~2015-09-15 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 12:48 [PATCH v3 0/4] serial: samsung: Fix UART status handling and other fixes Robert Baldyga
2015-09-15 12:48 ` [PATCH v3 1/4] serial: samsung: remove unused 'irq' parameter Robert Baldyga
2015-09-15 12:48 ` Robert Baldyga [this message]
2015-09-15 12:48 ` [PATCH v3 3/4] serial: samsung: introduce s3c24xx_serial_rx_drain_fifo() function Robert Baldyga
2015-09-17 7:27 ` Krzysztof Kozlowski
2015-09-17 7:35 ` Krzysztof Kozlowski
2015-09-15 12:49 ` [PATCH v3 4/4] serial: samsung: Fix UART status handling in DMA mode Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442321340-28167-3-git-send-email-r.baldyga@samsung.com \
--to=r.baldyga@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®