* [PATCH] crypto: crc32c-pclmul: use .rodata instead of .rotata
@ 2015-09-20 14:42 Nicolas Iooss
2015-09-21 15:10 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Iooss @ 2015-09-20 14:42 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, linux-crypto; +Cc: linux-kernel, Nicolas Iooss
Module crc32c-intel uses a special read-only data section named .rotata.
This section is defined for K_table, and its name seems to be a spelling
mistake for .rodata.
Fixes: 473946e674eb ("crypto: crc32c-pclmul - Shrink K_table to 32-bit words")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
index 225be06edc80..4fe27e074194 100644
--- a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
+++ b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
@@ -330,7 +330,7 @@ ENDPROC(crc_pcl)
## PCLMULQDQ tables
## Table is 128 entries x 2 words (8 bytes) each
################################################################
-.section .rotata, "a", %progbits
+.section .rodata, "a", %progbits
.align 8
K_table:
.long 0x493c7d27, 0x00000001
--
2.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: crc32c-pclmul: use .rodata instead of .rotata
2015-09-20 14:42 [PATCH] crypto: crc32c-pclmul: use .rodata instead of .rotata Nicolas Iooss
@ 2015-09-21 15:10 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-09-21 15:10 UTC (permalink / raw)
To: Nicolas Iooss; +Cc: David S. Miller, linux-crypto, linux-kernel
On Sun, Sep 20, 2015 at 04:42:36PM +0200, Nicolas Iooss wrote:
> Module crc32c-intel uses a special read-only data section named .rotata.
> This section is defined for K_table, and its name seems to be a spelling
> mistake for .rodata.
>
> Fixes: 473946e674eb ("crypto: crc32c-pclmul - Shrink K_table to 32-bit words")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Patch applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-21 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-20 14:42 [PATCH] crypto: crc32c-pclmul: use .rodata instead of .rotata Nicolas Iooss
2015-09-21 15:10 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®