From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 1/3] sgi-gru: use time_before()
Date: Mon, 21 Sep 2015 15:48:17 +0530 [thread overview]
Message-ID: <1442830699-20562-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1442830699-20562-1-git-send-email-sudipm.mukherjee@gmail.com>
From: Manuel Schölling <manuel.schoelling@gmx.de>
To be future-proof and for better readability the time comparisons are
modified to use time_before() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
reference at: https://patchwork.kernel.org/patch/4270701/
drivers/misc/sgi-gru/grumain.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index ae16c8c..1525870 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -930,6 +930,7 @@ int gru_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
{
struct gru_thread_state *gts;
unsigned long paddr, vaddr;
+ unsigned long expires;
vaddr = (unsigned long)vmf->virtual_address;
gru_dbg(grudev, "vma %p, vaddr 0x%lx (0x%lx)\n",
@@ -954,7 +955,8 @@ again:
mutex_unlock(>s->ts_ctxlock);
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(GRU_ASSIGN_DELAY); /* true hack ZZZ */
- if (gts->ts_steal_jiffies + GRU_STEAL_DELAY < jiffies)
+ expires = gts->ts_steal_jiffies + GRU_STEAL_DELAY;
+ if (time_before(expires, jiffies))
gru_steal_context(gts);
goto again;
}
--
1.9.1
next prev parent reply other threads:[~2015-09-21 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 10:18 [PATCH 0/3] drivers/misc/sgi-gru: unapplied patches and a new one Sudip Mukherjee
2015-09-21 10:18 ` Sudip Mukherjee [this message]
2015-09-21 10:18 ` [PATCH 2/3] misc: sgi-gru: gruhandles.c: Remove unused function Sudip Mukherjee
2015-09-21 10:18 ` [PATCH 3/3] drivers/misc/sgi-gru: fix return of error Sudip Mukherjee
2015-09-26 12:44 ` Dimitri Sivanich
2015-09-23 17:48 ` [PATCH 0/3] drivers/misc/sgi-gru: unapplied patches and a new one Dimitri Sivanich
2015-09-24 7:01 ` Sudip Mukherjee
2015-10-05 15:13 ` Sudip Mukherjee
2015-10-05 15:18 ` Dimitri Sivanich
2015-10-14 4:52 ` Sudip Mukherjee
2015-10-14 14:33 ` Dimitri Sivanich
2015-10-26 9:15 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442830699-20562-2-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®