From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 2/3] misc: sgi-gru: gruhandles.c: Remove unused function
Date: Mon, 21 Sep 2015 15:48:18 +0530 [thread overview]
Message-ID: <1442830699-20562-3-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1442830699-20562-1-git-send-email-sudipm.mukherjee@gmail.com>
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Remove the function tfh_restart() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
reference at: https://patchwork.kernel.org/patch/5557141/
drivers/misc/sgi-gru/gruhandles.c | 6 ------
drivers/misc/sgi-gru/gruhandles.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/misc/sgi-gru/gruhandles.c b/drivers/misc/sgi-gru/gruhandles.c
index 2f30bad..1ee8e82 100644
--- a/drivers/misc/sgi-gru/gruhandles.c
+++ b/drivers/misc/sgi-gru/gruhandles.c
@@ -196,12 +196,6 @@ void tfh_write_restart(struct gru_tlb_fault_handle *tfh,
start_instruction(tfh);
}
-void tfh_restart(struct gru_tlb_fault_handle *tfh)
-{
- tfh->opc = TFHOP_RESTART;
- start_instruction(tfh);
-}
-
void tfh_user_polling_mode(struct gru_tlb_fault_handle *tfh)
{
tfh->opc = TFHOP_USER_POLLING_MODE;
diff --git a/drivers/misc/sgi-gru/gruhandles.h b/drivers/misc/sgi-gru/gruhandles.h
index 3f998b9..3d7bd36 100644
--- a/drivers/misc/sgi-gru/gruhandles.h
+++ b/drivers/misc/sgi-gru/gruhandles.h
@@ -524,7 +524,6 @@ int tfh_write_only(struct gru_tlb_fault_handle *tfh, unsigned long paddr,
int gaa, unsigned long vaddr, int asid, int dirty, int pagesize);
void tfh_write_restart(struct gru_tlb_fault_handle *tfh, unsigned long paddr,
int gaa, unsigned long vaddr, int asid, int dirty, int pagesize);
-void tfh_restart(struct gru_tlb_fault_handle *tfh);
void tfh_user_polling_mode(struct gru_tlb_fault_handle *tfh);
void tfh_exception(struct gru_tlb_fault_handle *tfh);
--
1.9.1
next prev parent reply other threads:[~2015-09-21 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 10:18 [PATCH 0/3] drivers/misc/sgi-gru: unapplied patches and a new one Sudip Mukherjee
2015-09-21 10:18 ` [PATCH 1/3] sgi-gru: use time_before() Sudip Mukherjee
2015-09-21 10:18 ` Sudip Mukherjee [this message]
2015-09-21 10:18 ` [PATCH 3/3] drivers/misc/sgi-gru: fix return of error Sudip Mukherjee
2015-09-26 12:44 ` Dimitri Sivanich
2015-09-23 17:48 ` [PATCH 0/3] drivers/misc/sgi-gru: unapplied patches and a new one Dimitri Sivanich
2015-09-24 7:01 ` Sudip Mukherjee
2015-10-05 15:13 ` Sudip Mukherjee
2015-10-05 15:18 ` Dimitri Sivanich
2015-10-14 4:52 ` Sudip Mukherjee
2015-10-14 14:33 ` Dimitri Sivanich
2015-10-26 9:15 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442830699-20562-3-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®