* [PATCH] checkpatch: avoid showing uint*_t warnings for tools/ files
@ 2015-09-21 16:30 Octavian Purdila
2015-09-21 16:30 ` [PATCH] checkpatch: avoid showing BIT_ULL " Octavian Purdila
0 siblings, 1 reply; 2+ messages in thread
From: Octavian Purdila @ 2015-09-21 16:30 UTC (permalink / raw)
To: apw, joe; +Cc: linux-kernel, Octavian Purdila
tools/ files are compiled in userspace so using types like uint8_t is
legitimate.
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f2a1131..407eb6c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5221,8 +5221,9 @@ sub process {
"Using weak declarations can have unintended link defects\n" . $herecurr);
}
-# check for c99 types like uint8_t used outside of uapi/
+# check for c99 types like uint8_t used outside of uapi/ and tools/
if ($realfile !~ m@\binclude/uapi/@ &&
+ $realfile !~ m@\btools/@ &&
$line =~ /\b($Declare)\s*$Ident\s*[=;,\[]/) {
my $type = $1;
if ($type =~ /\b($typeC99Typedefs)\b/) {
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH] checkpatch: avoid showing BIT_ULL warnings for tools/ files
2015-09-21 16:30 [PATCH] checkpatch: avoid showing uint*_t warnings for tools/ files Octavian Purdila
@ 2015-09-21 16:30 ` Octavian Purdila
0 siblings, 0 replies; 2+ messages in thread
From: Octavian Purdila @ 2015-09-21 16:30 UTC (permalink / raw)
To: apw, joe; +Cc: linux-kernel, Octavian Purdila
Directly using shift operations in userspace compiled code should not
trigger warnings as BIT_ULL macros are not available outside the
kernel.
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 407eb6c..93557bf 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5527,7 +5527,8 @@ sub process {
if ($line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) {
my $ull = "";
$ull = "_ULL" if (defined($1) && $1 =~ /ll/i);
- if (CHK("BIT_MACRO",
+ if ($realfile !~ m@\btools/@ &&
+ CHK("BIT_MACRO",
"Prefer using the BIT$ull macro\n" . $herecurr) &&
$fix) {
$fixed[$fixlinenr] =~ s/\(?\s*1\s*[ulUL]*\s*<<\s*(\d+|$Ident)\s*\)?/BIT${ull}($1)/;
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-21 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-21 16:30 [PATCH] checkpatch: avoid showing uint*_t warnings for tools/ files Octavian Purdila
2015-09-21 16:30 ` [PATCH] checkpatch: avoid showing BIT_ULL " Octavian Purdila
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®