From: Michael Ellerman <mpe@ellerman.id.au>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Shuah Khan <shuahkh@osg.samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pavel Emelyanov <xemul@parallels.com>,
Will Deacon <Will.Deacon@arm.com>
Subject: Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number definition
Date: Wed, 23 Sep 2015 19:55:09 +1000 [thread overview]
Message-ID: <1443002109.9279.1.camel@ellerman.id.au> (raw)
In-Reply-To: <56018CA0.8050600@arm.com>
On Tue, 2015-09-22 at 18:15 +0100, Andre Przywara wrote:
> On 22/09/15 15:06, Andrea Arcangeli wrote:
> > Andre, could you see if linux-next (which includes -mm) works for you
> > by just running "cd tools/testing/selftests/vm/ && make"? If there's
> > any further change required could you diff it against linux-next?
>
> This doesn't compile now for me, because it looks into
> /usr/include/asm/unistd.h, which I keep to the distribution copy of it.
> Also linux/userfaultfd.h is missing, because it's brand new.
...
> I guess the right solution would be to hack the Makefile to set the
> include path to the kernel's copy of include/uapi, though I am not sure
> this works cleanly for different architectures and separate build
> directories. I will give this a try ...
Not that's not the right solution.
The right solution is to export the kernel headers, the Makefile will pick them
up (at least in linux-next):
$ cd linux
$ make headers_install
$ ls usr/include/
asm/ asm-generic/ drm/ linux/ misc/ mtd/ rdma/ scsi/ sound/ uapi/ video/ xen/
$ make -C tools/testing/selftests TARGETS=vm
...
$ ls tools/testing/selftests/vm/userfaultfd
tools/testing/selftests/vm/userfaultfd*
cheers
next prev parent reply other threads:[~2015-09-23 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 10:45 [PATCH 0/2] selftests/userfaultfd: fix build Andre Przywara
2015-09-22 10:45 ` [PATCH 1/2] userfaultfd: remove kernel header include from uapi header Andre Przywara
2015-09-22 10:45 ` [PATCH 2/2] selftests/userfaultfd: improve syscall number definition Andre Przywara
2015-09-22 13:49 ` Shuah Khan
2015-09-22 14:06 ` Andrea Arcangeli
2015-09-22 17:15 ` Andre Przywara
2015-09-23 9:55 ` Michael Ellerman [this message]
2015-09-23 13:11 ` Andre Przywara
2015-09-24 2:04 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443002109.9279.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=Will.Deacon@arm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andre.przywara@arm.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®