From: "Felipe F. Tonello" <eu@felipetonello.com>
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Peter Chen <Peter.Chen@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
"Felipe F. Tonello" <eu@felipetonello.com>
Subject: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done
Date: Wed, 23 Sep 2015 13:01:44 +0100 [thread overview]
Message-ID: <1443009704-30320-1-git-send-email-eu@felipetonello.com> (raw)
req->actual == req->length means that there is no data left to enqueue,
so free the request.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
Changes in v2:
* Re enqueue not fully completed requests, instead of read ALSA buffers.
drivers/usb/gadget/function/f_midi.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index edb84ca..62356cf 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -256,10 +256,12 @@ f_midi_complete(struct usb_ep *ep, struct usb_request *req)
/* We received stuff. req is queued again, below */
f_midi_handle_out_data(ep, req);
} else if (ep == midi->in_ep) {
- /* Our transmit completed. See if there's more to go.
- * f_midi_transmit eats req, don't queue it again. */
- f_midi_transmit(midi, req);
- return;
+ /* Our transmit completed. If there is no more to go,
+ don't queue it again. */
+ if (req->actual == req->length) {
+ free_ep_req(ep, req);
+ return;
+ }
}
break;
--
2.1.4
next reply other threads:[~2015-09-23 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 12:01 Felipe F. Tonello [this message]
2015-09-23 13:12 ` Sergei Shtylyov
2015-09-24 1:38 ` Peter Chen
2015-09-24 6:44 ` Clemens Ladisch
2015-09-25 9:22 ` Felipe Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443009704-30320-1-git-send-email-eu@felipetonello.com \
--to=eu@felipetonello.com \
--cc=Peter.Chen@freescale.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®