From: Wang Long <long.wanglong@huawei.com>
To: <shuahkh@osg.samsung.com>, <dvhart@infradead.org>, <mpe@ellerman.id.au>
Cc: <keescook@chromium.org>, <davem@davemloft.net>,
<luto@amacapital.net>, <wad@chromium.org>,
<akpm@linux-foundation.org>, <long.wanglong@huawei.com>,
<gorcunov@openvz.org>, <cov@codeaurora.org>,
<mathieu.desnoyers@efficios.com>, <bobby.prani@gmail.com>,
<tyler.baker@linaro.org>, <tim.bird@sonymobile.com>,
<josh@joshtriplett.org>, <aarcange@redhat.com>,
<andrej.skvortzov@gmail.com>, <sjayaram@akamai.com>,
<treding@nvidia.com>, <mingo@kernel.org>,
<naresh.kamboju@linaro.org>, <alexey.kodanev@oracle.com>,
<linux-api@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<wanglong@laoqinren.net>
Subject: [PATCH] kselftest: replace $(RM) with rm -f command
Date: Mon, 28 Sep 2015 02:10:17 +0000 [thread overview]
Message-ID: <1443406217-137773-1-git-send-email-long.wanglong@huawei.com> (raw)
In-Reply-To: <20150925154415.GC38748@vmdeb7>
Some test's Makefile using "$(RM)" while the other's
using "rm -f". It is better to use one of them in all
tests.
"rm -f" is better, because it is less magic, and everyone
konws what is does.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
tools/testing/selftests/capabilities/Makefile | 2 +-
tools/testing/selftests/kcmp/Makefile | 2 +-
tools/testing/selftests/membarrier/Makefile | 2 +-
tools/testing/selftests/memfd/Makefile | 2 +-
tools/testing/selftests/net/Makefile | 2 +-
tools/testing/selftests/seccomp/Makefile | 2 +-
tools/testing/selftests/size/Makefile | 2 +-
tools/testing/selftests/vm/Makefile | 2 +-
tools/testing/selftests/x86/Makefile | 2 +-
tools/testing/selftests/zram/Makefile | 2 +-
10 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/tools/testing/selftests/capabilities/Makefile b/tools/testing/selftests/capabilities/Makefile
index 8c8f0c1..dcc1972 100644
--- a/tools/testing/selftests/capabilities/Makefile
+++ b/tools/testing/selftests/capabilities/Makefile
@@ -12,7 +12,7 @@ CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng
all: $(TARGETS)
clean:
- $(RM) $(TARGETS)
+ rm -f $(TARGETS)
$(TARGETS): %: %.c
$(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
index 2ae7450..2deaee0 100644
--- a/tools/testing/selftests/kcmp/Makefile
+++ b/tools/testing/selftests/kcmp/Makefile
@@ -7,4 +7,4 @@ TEST_PROGS := kcmp_test
include ../lib.mk
clean:
- $(RM) kcmp_test kcmp-test-file
+ rn -f kcmp_test kcmp-test-file
diff --git a/tools/testing/selftests/membarrier/Makefile b/tools/testing/selftests/membarrier/Makefile
index a1a9708..f23fc58 100644
--- a/tools/testing/selftests/membarrier/Makefile
+++ b/tools/testing/selftests/membarrier/Makefile
@@ -7,4 +7,4 @@ all: $(TEST_PROGS)
include ../lib.mk
clean:
- $(RM) $(TEST_PROGS)
+ rm -f $(TEST_PROGS)
diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile
index 3e7eb79..068fa93 100644
--- a/tools/testing/selftests/memfd/Makefile
+++ b/tools/testing/selftests/memfd/Makefile
@@ -19,4 +19,4 @@ run_fuse: build_fuse
@./run_fuse_test.sh || echo "fuse_test: [FAIL]"
clean:
- $(RM) memfd_test fuse_test
+ rm -f memfd_test fuse_test
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index fac4782..ec7eaa4 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -16,4 +16,4 @@ TEST_FILES := $(NET_PROGS)
include ../lib.mk
clean:
- $(RM) $(NET_PROGS)
+ rm -f $(NET_PROGS)
diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
index 8401e87..c16072a 100644
--- a/tools/testing/selftests/seccomp/Makefile
+++ b/tools/testing/selftests/seccomp/Makefile
@@ -7,4 +7,4 @@ all: $(TEST_PROGS)
include ../lib.mk
clean:
- $(RM) $(TEST_PROGS)
+ rm -f $(TEST_PROGS)
diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile
index bbd0b53..cefe914 100644
--- a/tools/testing/selftests/size/Makefile
+++ b/tools/testing/selftests/size/Makefile
@@ -8,4 +8,4 @@ TEST_PROGS := get_size
include ../lib.mk
clean:
- $(RM) get_size
+ rm -f get_size
diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
index 3c53cac..26663c7 100644
--- a/tools/testing/selftests/vm/Makefile
+++ b/tools/testing/selftests/vm/Makefile
@@ -24,4 +24,4 @@ TEST_FILES := $(BINARIES)
include ../lib.mk
clean:
- $(RM) $(BINARIES)
+ rm -f $(BINARIES)
diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 29089b2..48b2406 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -32,7 +32,7 @@ all_32: $(BINARIES_32)
all_64: $(BINARIES_64)
clean:
- $(RM) $(BINARIES_32) $(BINARIES_64)
+ rm -f $(BINARIES_32) $(BINARIES_64)
$(TARGETS_C_32BIT_ALL:%=%_32): %_32: %.c
$(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
diff --git a/tools/testing/selftests/zram/Makefile b/tools/testing/selftests/zram/Makefile
index 29d8034..e1591c8 100644
--- a/tools/testing/selftests/zram/Makefile
+++ b/tools/testing/selftests/zram/Makefile
@@ -6,4 +6,4 @@ TEST_FILES := zram01.sh zram02.sh zram_lib.sh
include ../lib.mk
clean:
- $(RM) err.log
+ rm -f err.log
--
1.8.3.4
next prev parent reply other threads:[~2015-09-28 2:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 9:40 [PATCH] kselftest: using built-in rule when delete file Wang Long
2015-09-24 1:46 ` Michael Ellerman
2015-09-24 2:05 ` long.wanglong
2015-09-24 2:07 ` Michael Ellerman
2015-09-25 15:44 ` Darren Hart
2015-09-28 2:03 ` long.wanglong
2015-09-28 2:10 ` Wang Long [this message]
2015-09-28 3:16 ` [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers
2015-09-28 5:11 ` Cam Hutchison
2015-09-29 9:57 ` Michael Ellerman
2015-09-29 11:21 ` [PATCH] kselftest: replace rm -f command with $(RM) Wang Long
2015-09-29 17:45 ` [PATCH] kselftest: replace $(RM) with rm -f command Kees Cook
2015-10-03 4:38 ` Darren Hart
2015-10-03 14:11 ` Mathieu Desnoyers
2015-10-03 17:55 ` Josh Triplett
2015-10-03 18:05 ` Mathieu Desnoyers
2015-09-28 7:26 ` Yuan Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443406217-137773-1-git-send-email-long.wanglong@huawei.com \
--to=long.wanglong@huawei.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexey.kodanev@oracle.com \
--cc=andrej.skvortzov@gmail.com \
--cc=bobby.prani@gmail.com \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dvhart@infradead.org \
--cc=gorcunov@openvz.org \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=naresh.kamboju@linaro.org \
--cc=shuahkh@osg.samsung.com \
--cc=sjayaram@akamai.com \
--cc=tim.bird@sonymobile.com \
--cc=treding@nvidia.com \
--cc=tyler.baker@linaro.org \
--cc=wad@chromium.org \
--cc=wanglong@laoqinren.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®