From: "long.wanglong" <long.wanglong@huawei.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: <shuahkh@osg.samsung.com>, <sam.bobroff@au1.ibm.com>,
<aneesh.kumar@linux.vnet.ibm.com>, <paulus@samba.or>,
<khandual@linux.vnet.ibm.com>, <gkurz@linux.vnet.ibm.com>,
<anton@samba.org>, <dvhart@linux.intel.com>, <tglx@linutronix.de>,
<john.stultz@linaro.org>, <linux-kernel@vger.kernel.org>,
<wanglong@laoqinren.net>, <linux-doc@vger.kernel.org>,
<peifeiyue@huawei.com>
Subject: Re: [PATCH] kselftest: using built-in rule when delete file
Date: Thu, 24 Sep 2015 10:05:37 +0800 [thread overview]
Message-ID: <56035A71.9040301@huawei.com> (raw)
In-Reply-To: <1443059210.21433.1.camel@ellerman.id.au>
On 2015/9/24 9:46, Michael Ellerman wrote:
> On Wed, 2015-09-23 at 09:40 +0000, Wang Long wrote:
>> Use make's built-in rules to when delete a file
>> or delete files.
>
> It's not a built-in rule, it's a variable.
Sorry，I did not describe clearly. It is a variable used as
name of program in built-in rules.
>
> Personally I think using rm directly is clearer, but I guess this is fine. Do
> you actually want to override $RM ?
>
So far, I do not want to override $(RM). But I found that some test's Makefile
using *$(RM)* while the other's using *rm -f*, I think it is better to use one
of them in all unit tests.
Do you think which one is better?
Best Regards
Wang Long
> cheers
>
>
>
> .
>
next prev parent reply other threads:[~2015-09-24 2:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 9:40 Wang Long
2015-09-24 1:46 ` Michael Ellerman
2015-09-24 2:05 ` long.wanglong [this message]
2015-09-24 2:07 ` Michael Ellerman
2015-09-25 15:44 ` Darren Hart
2015-09-28 2:03 ` long.wanglong
2015-09-28 2:10 ` [PATCH] kselftest: replace $(RM) with rm -f command Wang Long
2015-09-28 3:16 ` Mathieu Desnoyers
2015-09-28 5:11 ` Cam Hutchison
2015-09-29 9:57 ` Michael Ellerman
2015-09-29 11:21 ` [PATCH] kselftest: replace rm -f command with $(RM) Wang Long
2015-09-29 17:45 ` [PATCH] kselftest: replace $(RM) with rm -f command Kees Cook
2015-10-03 4:38 ` Darren Hart
2015-10-03 14:11 ` Mathieu Desnoyers
2015-10-03 17:55 ` Josh Triplett
2015-10-03 18:05 ` Mathieu Desnoyers
2015-09-28 7:26 ` Yuan Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56035A71.9040301@huawei.com \
--to=long.wanglong@huawei.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=dvhart@linux.intel.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=john.stultz@linaro.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.or \
--cc=peifeiyue@huawei.com \
--cc=sam.bobroff@au1.ibm.com \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
--cc=wanglong@laoqinren.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome