From: Yann Droneaud <ydroneaud@opteya.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
William Cohen <wcohen@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] perf tools: report PERF_FLAG_FD_CLOEXEC probing error once
Date: Fri, 02 Oct 2015 15:43:31 +0200 [thread overview]
Message-ID: <1443793411.3188.25.camel@opteya.com> (raw)
In-Reply-To: <20151002132041.GB1673@krava.brq.redhat.com>
Le vendredi 02 octobre 2015 à 15:20 +0200, Jiri Olsa a écrit :
> On Thu, Oct 01, 2015 at 05:16:26PM +0200, Yann Droneaud wrote:
> > In case of failure, unrelated to PERF_FLAG_FD_CLOEXEC,
> > perf_flag_probe() reports the error twice. For example:
> >
> > $ perf record ls
> > Error:
> > perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected
> > error 16 (Device or resource busy)
> > perf_event_open(..., 0) failed unexpectedly with error 16 (Device
> > or resource busy)
>
> so this error message is no longer possible due to your earlier patch
> right?
>
My bad, the error used to illustrate the behavior is not well choosed.
> could you please provide current 'before&after' output into changelog
> otherwise it looks ok
>
OK. I'm updating the message.
Regards.
--
Yann Droneaud
OPTEYA
prev parent reply other threads:[~2015-10-02 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 15:16 [PATCH v2 0/2] perf tool: improve error handling in perf_flag_probe() Yann Droneaud
2015-10-01 15:18 ` [PATCH v2 1/2] perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY error Yann Droneaud
[not found] ` <20151001205247.GA4445@krava.redhat.com>
2015-10-01 21:32 ` Yann Droneaud
2015-10-02 13:19 ` Jiri Olsa
2015-10-01 15:18 ` [PATCH v2 2/2] perf tools: report PERF_FLAG_FD_CLOEXEC probing error once Yann Droneaud
[not found] ` <20151002132041.GB1673@krava.brq.redhat.com>
2015-10-02 13:43 ` Yann Droneaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443793411.3188.25.camel@opteya.com \
--to=ydroneaud@opteya.com \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=wcohen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome