* [PATCH 1/1] integrity: prevent loading untrusted certificates to IMA trusted keyring
@ 2015-09-10 19:06 Dmitry Kasatkin
2015-09-23 20:08 ` Dmitry Kasatkin
2015-10-02 17:39 ` Mimi Zohar
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Kasatkin @ 2015-09-10 19:06 UTC (permalink / raw)
To: zohar, linux-security-module, linux-kernel; +Cc: Dmitry Kasatkin, stable
If IMA_LOAD_X509 is enabled either directly or indirectly via
IMA_APPRAISE_SIGNED_INIT, it enables certificate loading to the IMA trusted
keyring from the kernel. Due to the overlook, KEY_ALLOC_TRUSTED was used in the
key_create_or_update() to create keys within the kernel, which caused
overriding certificate verification result and allowed to load self-signed or
wrongly signed certificates.
This patch just removes this option.
Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@huawei.com>
Cc: <stable@vger.kernel.org> # 3.19+
---
security/integrity/digsig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
index 36fb6b5..5be9ffb 100644
--- a/security/integrity/digsig.c
+++ b/security/integrity/digsig.c
@@ -105,7 +105,7 @@ int __init integrity_load_x509(const unsigned int id, const char *path)
rc,
((KEY_POS_ALL & ~KEY_POS_SETATTR) |
KEY_USR_VIEW | KEY_USR_READ),
- KEY_ALLOC_NOT_IN_QUOTA | KEY_ALLOC_TRUSTED);
+ KEY_ALLOC_NOT_IN_QUOTA);
if (IS_ERR(key)) {
rc = PTR_ERR(key);
pr_err("Problem loading X.509 certificate (%d): %s\n",
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] integrity: prevent loading untrusted certificates to IMA trusted keyring
2015-09-10 19:06 [PATCH 1/1] integrity: prevent loading untrusted certificates to IMA trusted keyring Dmitry Kasatkin
@ 2015-09-23 20:08 ` Dmitry Kasatkin
2015-10-02 17:39 ` Mimi Zohar
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Kasatkin @ 2015-09-23 20:08 UTC (permalink / raw)
To: Mimi Zohar, linux-security-module, linux-kernel; +Cc: Dmitry Kasatkin, stable
Hi,
Apply this patch, please...
Dmitry
On Thu, Sep 10, 2015 at 10:06 PM, Dmitry Kasatkin
<dmitry.kasatkin@gmail.com> wrote:
> If IMA_LOAD_X509 is enabled either directly or indirectly via
> IMA_APPRAISE_SIGNED_INIT, it enables certificate loading to the IMA trusted
> keyring from the kernel. Due to the overlook, KEY_ALLOC_TRUSTED was used in the
> key_create_or_update() to create keys within the kernel, which caused
> overriding certificate verification result and allowed to load self-signed or
> wrongly signed certificates.
>
> This patch just removes this option.
>
> Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@huawei.com>
> Cc: <stable@vger.kernel.org> # 3.19+
> ---
> security/integrity/digsig.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> index 36fb6b5..5be9ffb 100644
> --- a/security/integrity/digsig.c
> +++ b/security/integrity/digsig.c
> @@ -105,7 +105,7 @@ int __init integrity_load_x509(const unsigned int id, const char *path)
> rc,
> ((KEY_POS_ALL & ~KEY_POS_SETATTR) |
> KEY_USR_VIEW | KEY_USR_READ),
> - KEY_ALLOC_NOT_IN_QUOTA | KEY_ALLOC_TRUSTED);
> + KEY_ALLOC_NOT_IN_QUOTA);
> if (IS_ERR(key)) {
> rc = PTR_ERR(key);
> pr_err("Problem loading X.509 certificate (%d): %s\n",
> --
> 2.1.4
>
--
Thanks,
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] integrity: prevent loading untrusted certificates to IMA trusted keyring
2015-09-10 19:06 [PATCH 1/1] integrity: prevent loading untrusted certificates to IMA trusted keyring Dmitry Kasatkin
2015-09-23 20:08 ` Dmitry Kasatkin
@ 2015-10-02 17:39 ` Mimi Zohar
1 sibling, 0 replies; 3+ messages in thread
From: Mimi Zohar @ 2015-10-02 17:39 UTC (permalink / raw)
To: Dmitry Kasatkin
Cc: linux-security-module, linux-kernel, Dmitry Kasatkin, stable
On Thu, 2015-09-10 at 22:06 +0300, Dmitry Kasatkin wrote:
> If IMA_LOAD_X509 is enabled either directly or indirectly via
> IMA_APPRAISE_SIGNED_INIT, it enables certificate loading to the IMA trusted
> keyring from the kernel. Due to the overlook, KEY_ALLOC_TRUSTED was used in the
> key_create_or_update() to create keys within the kernel, which caused
> overriding certificate verification result and allowed to load self-signed or
> wrongly signed certificates.
>
> This patch just removes this option.
Thanks!
Mimi
>
> Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@huawei.com>
> Cc: <stable@vger.kernel.org> # 3.19+
> ---
> security/integrity/digsig.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> index 36fb6b5..5be9ffb 100644
> --- a/security/integrity/digsig.c
> +++ b/security/integrity/digsig.c
> @@ -105,7 +105,7 @@ int __init integrity_load_x509(const unsigned int id, const char *path)
> rc,
> ((KEY_POS_ALL & ~KEY_POS_SETATTR) |
> KEY_USR_VIEW | KEY_USR_READ),
> - KEY_ALLOC_NOT_IN_QUOTA | KEY_ALLOC_TRUSTED);
> + KEY_ALLOC_NOT_IN_QUOTA);
> if (IS_ERR(key)) {
> rc = PTR_ERR(key);
> pr_err("Problem loading X.509 certificate (%d): %s\n",
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-02 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-10 19:06 [PATCH 1/1] integrity: prevent loading untrusted certificates to IMA trusted keyring Dmitry Kasatkin
2015-09-23 20:08 ` Dmitry Kasatkin
2015-10-02 17:39 ` Mimi Zohar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome