From: Luca Coelho <luca@coelho.fi>
To: Denys Vlasenko <dvlasenk@redhat.com>,
Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
Gregory Greenman <gregory.greenman@intel.com>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Deinline iwl_write8/write32/read32()
Date: Mon, 05 Oct 2015 15:26:14 +0300 [thread overview]
Message-ID: <1444047974.27220.10.camel@coelho.fi> (raw)
In-Reply-To: <1443106735-9661-1-git-send-email-dvlasenk@redhat.com>
Hi Denys,
On Thu, 2015-09-24 at 16:58 +0200, Denys Vlasenko wrote:
> With this .config: http://busybox.net/~vda/kernel_config_ALLYES_Os,
> after deinlining these functions have sizes and callsite counts
> as follows:
>
> iwl_write8: 315 bytes, 3 calls
> iwl_write32: 296 bytes, 90 calls
> iwl_read32: 278 bytes, 51 calls
>
> Total size reduction is about 40 kbytes.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Johannes Berg <johannes.berg@intel.com>
> CC: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> CC: Intel Linux Wireless <ilw@linux.intel.com>
> CC: Gregory Greenman <gregory.greenman@intel.com>
> CC: John Linville <linville@tuxdriver.com>
> CC: linux-wireless@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
Emmanuel already wrote and applied a patch like this. Check here:
http://mid.gmane.org/1442869141-31637-4-git-send-email-luca@coelho.fi
Thanks for your patch anyway and for reporting this. :)
--
Cheers,
Luca.
prev parent reply other threads:[~2015-10-05 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 14:58 Denys Vlasenko
2015-10-05 12:26 ` Luca Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444047974.27220.10.camel@coelho.fi \
--to=luca@coelho.fi \
--cc=dvlasenk@redhat.com \
--cc=emmanuel.grumbach@intel.com \
--cc=gregory.greenman@intel.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®