* [PATCH] Staging: fbtft: Use BIT macro
@ 2015-10-06 3:15 Ronit Halder
2015-10-06 8:01 ` Michał Kępień
0 siblings, 1 reply; 2+ messages in thread
From: Ronit Halder @ 2015-10-06 3:15 UTC (permalink / raw)
To: thomas.petazzoni; +Cc: gregkh, noralf, devel, linux-kernel, Ronit Halder
Replace (1 << x) by BIT(x)
Signed-off-by: Ronit halder <ronit.crj@gmail.com>
---
drivers/staging/fbtft/fb_ssd1351.c | 4 +--
drivers/staging/fbtft/fbtft.h | 56 +++++++++++++++++++-------------------
2 files changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
index eb45b27..28cc5d9 100644
--- a/drivers/staging/fbtft/fb_ssd1351.c
+++ b/drivers/staging/fbtft/fb_ssd1351.c
@@ -80,10 +80,10 @@ static int set_var(struct fbtft_par *par)
switch (par->info->var.rotate) {
case 0:
- write_reg(par, 0xA0, remap | 0x00 | 1<<4);
+ write_reg(par, 0xA0, remap | 0x00 | BIT(4));
break;
case 270:
- write_reg(par, 0xA0, remap | 0x03 | 1<<4);
+ write_reg(par, 0xA0, remap | 0x03 | BIT(4));
break;
case 180:
write_reg(par, 0xA0, remap | 0x02);
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 6dd42b2..375af6b 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -374,39 +374,39 @@ module_exit(fbtft_driver_module_exit);
#define DEBUG_LEVEL_6 (DEBUG_LEVEL_4 | DEBUG_LEVEL_5)
#define DEBUG_LEVEL_7 0xFFFFFFFF
-#define DEBUG_DRIVER_INIT_FUNCTIONS (1<<3)
-#define DEBUG_TIME_FIRST_UPDATE (1<<4)
-#define DEBUG_TIME_EACH_UPDATE (1<<5)
-#define DEBUG_DEFERRED_IO (1<<6)
-#define DEBUG_FBTFT_INIT_FUNCTIONS (1<<7)
+#define DEBUG_DRIVER_INIT_FUNCTIONS BIT(3)
+#define DEBUG_TIME_FIRST_UPDATE BIT(4)
+#define DEBUG_TIME_EACH_UPDATE BIT(5)
+#define DEBUG_DEFERRED_IO BIT(6)
+#define DEBUG_FBTFT_INIT_FUNCTIONS BIT(7)
/* fbops */
-#define DEBUG_FB_READ (1<<8)
-#define DEBUG_FB_WRITE (1<<9)
-#define DEBUG_FB_FILLRECT (1<<10)
-#define DEBUG_FB_COPYAREA (1<<11)
-#define DEBUG_FB_IMAGEBLIT (1<<12)
-#define DEBUG_FB_SETCOLREG (1<<13)
-#define DEBUG_FB_BLANK (1<<14)
+#define DEBUG_FB_READ BIT(8)
+#define DEBUG_FB_WRITE BIT(9)
+#define DEBUG_FB_FILLRECT BIT(10)
+#define DEBUG_FB_COPYAREA BIT(11)
+#define DEBUG_FB_IMAGEBLIT BIT(12)
+#define DEBUG_FB_SETCOLREG BIT(13)
+#define DEBUG_FB_BLANK BIT(14)
-#define DEBUG_SYSFS (1<<16)
+#define DEBUG_SYSFS BIT(16)
/* fbtftops */
-#define DEBUG_BACKLIGHT (1<<17)
-#define DEBUG_READ (1<<18)
-#define DEBUG_WRITE (1<<19)
-#define DEBUG_WRITE_VMEM (1<<20)
-#define DEBUG_WRITE_REGISTER (1<<21)
-#define DEBUG_SET_ADDR_WIN (1<<22)
-#define DEBUG_RESET (1<<23)
-#define DEBUG_MKDIRTY (1<<24)
-#define DEBUG_UPDATE_DISPLAY (1<<25)
-#define DEBUG_INIT_DISPLAY (1<<26)
-#define DEBUG_BLANK (1<<27)
-#define DEBUG_REQUEST_GPIOS (1<<28)
-#define DEBUG_FREE_GPIOS (1<<29)
-#define DEBUG_REQUEST_GPIOS_MATCH (1<<30)
-#define DEBUG_VERIFY_GPIOS (1<<31)
+#define DEBUG_BACKLIGHT BIT(17)
+#define DEBUG_READ BIT(18)
+#define DEBUG_WRITE BIT(19)
+#define DEBUG_WRITE_VMEM BIT(20)
+#define DEBUG_WRITE_REGISTER BIT(21)
+#define DEBUG_SET_ADDR_WIN BIT(22)
+#define DEBUG_RESET BIT(23)
+#define DEBUG_MKDIRTY BIT(24)
+#define DEBUG_UPDATE_DISPLAY BIT(25)
+#define DEBUG_INIT_DISPLAY BIT(26)
+#define DEBUG_BLANK BIT(27)
+#define DEBUG_REQUEST_GPIOS BIT(28)
+#define DEBUG_FREE_GPIOS BIT(29)
+#define DEBUG_REQUEST_GPIOS_MATCH BIT(30)
+#define DEBUG_VERIFY_GPIOS BIT(31)
#define fbtft_init_dbg(dev, format, arg...) \
do { \
--
2.6.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: fbtft: Use BIT macro
2015-10-06 3:15 [PATCH] Staging: fbtft: Use BIT macro Ronit Halder
@ 2015-10-06 8:01 ` Michał Kępień
0 siblings, 0 replies; 2+ messages in thread
From: Michał Kępień @ 2015-10-06 8:01 UTC (permalink / raw)
To: Ronit Halder; +Cc: thomas.petazzoni, devel, gregkh, noralf, linux-kernel
> Replace (1 << x) by BIT(x)
>
> Signed-off-by: Ronit halder <ronit.crj@gmail.com>
Minor nit: you stopped capitalizing your surname in your SoBs sometime
between Jul 10 and Aug 19 (judging from a quick peek at git log).
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index 6dd42b2..375af6b 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -374,39 +374,39 @@ module_exit(fbtft_driver_module_exit);
> #define DEBUG_LEVEL_6 (DEBUG_LEVEL_4 | DEBUG_LEVEL_5)
> #define DEBUG_LEVEL_7 0xFFFFFFFF
>
> -#define DEBUG_DRIVER_INIT_FUNCTIONS (1<<3)
> -#define DEBUG_TIME_FIRST_UPDATE (1<<4)
> -#define DEBUG_TIME_EACH_UPDATE (1<<5)
> -#define DEBUG_DEFERRED_IO (1<<6)
> -#define DEBUG_FBTFT_INIT_FUNCTIONS (1<<7)
> +#define DEBUG_DRIVER_INIT_FUNCTIONS BIT(3)
> +#define DEBUG_TIME_FIRST_UPDATE BIT(4)
> +#define DEBUG_TIME_EACH_UPDATE BIT(5)
> +#define DEBUG_DEFERRED_IO BIT(6)
You put one tab too much in here.
> +#define DEBUG_FBTFT_INIT_FUNCTIONS BIT(7)
>
> /* fbops */
> -#define DEBUG_FB_READ (1<<8)
> -#define DEBUG_FB_WRITE (1<<9)
> -#define DEBUG_FB_FILLRECT (1<<10)
> -#define DEBUG_FB_COPYAREA (1<<11)
> -#define DEBUG_FB_IMAGEBLIT (1<<12)
> -#define DEBUG_FB_SETCOLREG (1<<13)
> -#define DEBUG_FB_BLANK (1<<14)
> +#define DEBUG_FB_READ BIT(8)
> +#define DEBUG_FB_WRITE BIT(9)
> +#define DEBUG_FB_FILLRECT BIT(10)
> +#define DEBUG_FB_COPYAREA BIT(11)
> +#define DEBUG_FB_IMAGEBLIT BIT(12)
> +#define DEBUG_FB_SETCOLREG BIT(13)
> +#define DEBUG_FB_BLANK BIT(14)
>
> -#define DEBUG_SYSFS (1<<16)
> +#define DEBUG_SYSFS BIT(16)
>
> /* fbtftops */
> -#define DEBUG_BACKLIGHT (1<<17)
> -#define DEBUG_READ (1<<18)
> -#define DEBUG_WRITE (1<<19)
> -#define DEBUG_WRITE_VMEM (1<<20)
> -#define DEBUG_WRITE_REGISTER (1<<21)
> -#define DEBUG_SET_ADDR_WIN (1<<22)
> -#define DEBUG_RESET (1<<23)
> -#define DEBUG_MKDIRTY (1<<24)
> -#define DEBUG_UPDATE_DISPLAY (1<<25)
> -#define DEBUG_INIT_DISPLAY (1<<26)
> -#define DEBUG_BLANK (1<<27)
> -#define DEBUG_REQUEST_GPIOS (1<<28)
> -#define DEBUG_FREE_GPIOS (1<<29)
> -#define DEBUG_REQUEST_GPIOS_MATCH (1<<30)
> -#define DEBUG_VERIFY_GPIOS (1<<31)
> +#define DEBUG_BACKLIGHT BIT(17)
> +#define DEBUG_READ BIT(18)
> +#define DEBUG_WRITE BIT(19)
> +#define DEBUG_WRITE_VMEM BIT(20)
> +#define DEBUG_WRITE_REGISTER BIT(21)
> +#define DEBUG_SET_ADDR_WIN BIT(22)
> +#define DEBUG_RESET BIT(23)
> +#define DEBUG_MKDIRTY BIT(24)
> +#define DEBUG_UPDATE_DISPLAY BIT(25)
> +#define DEBUG_INIT_DISPLAY BIT(26)
> +#define DEBUG_BLANK BIT(27)
> +#define DEBUG_REQUEST_GPIOS BIT(28)
> +#define DEBUG_FREE_GPIOS BIT(29)
> +#define DEBUG_REQUEST_GPIOS_MATCH BIT(30)
> +#define DEBUG_VERIFY_GPIOS BIT(31)
Why did you replace spaces with tabs only in the first hunk of your
patch?
--
Best regards,
Michał Kępień
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-06 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-06 3:15 [PATCH] Staging: fbtft: Use BIT macro Ronit Halder
2015-10-06 8:01 ` Michał Kępień
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®