From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Andy Gross <agross@codeaurora.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-soc@vger.kernel.org>,
Fengwei Yin <fengwei.yin@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 4/7] soc: qcom: smd: Support multiple channels per sdev
Date: Fri, 9 Oct 2015 13:48:02 -0700 [thread overview]
Message-ID: <1444423685-14717-5-git-send-email-bjorn.andersson@sonymobile.com> (raw)
In-Reply-To: <1444423685-14717-1-git-send-email-bjorn.andersson@sonymobile.com>
This patch allows chaining additional channels to a SMD device, enabling
implementation of multi-channel SMD devies - like Bluetooth.
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
Changes since v1:
- New patch
drivers/soc/qcom/smd.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
index 669bda585dad..4c55708aac50 100644
--- a/drivers/soc/qcom/smd.c
+++ b/drivers/soc/qcom/smd.c
@@ -193,6 +193,7 @@ struct qcom_smd_channel {
int pkt_size;
struct list_head list;
+ struct list_head dev_list;
};
/**
@@ -885,6 +886,8 @@ static int qcom_smd_dev_remove(struct device *dev)
struct qcom_smd_device *qsdev = to_smd_device(dev);
struct qcom_smd_driver *qsdrv = to_smd_driver(dev);
struct qcom_smd_channel *channel = qsdev->channel;
+ struct qcom_smd_channel *tmp;
+ struct qcom_smd_channel *ch;
qcom_smd_channel_set_state(channel, SMD_CHANNEL_CLOSING);
@@ -904,10 +907,14 @@ static int qcom_smd_dev_remove(struct device *dev)
qsdrv->remove(qsdev);
/*
- * The client is now gone, cleanup and reset the channel state.
+ * The client is now gone, close and release all channels associated
+ * with this sdev
*/
- channel->qsdev = NULL;
- qcom_smd_channel_close(channel);
+ list_for_each_entry_safe(ch, tmp, &channel->dev_list, dev_list) {
+ qcom_smd_channel_close(ch);
+ list_del(&ch->dev_list);
+ ch->qsdev = NULL;
+ }
return 0;
}
@@ -1056,6 +1063,7 @@ static struct qcom_smd_channel *qcom_smd_create_channel(struct qcom_smd_edge *ed
if (!channel)
return ERR_PTR(-ENOMEM);
+ INIT_LIST_HEAD(&channel->dev_list);
channel->edge = edge;
channel->name = devm_kstrdup(smd->dev, name, GFP_KERNEL);
if (!channel->name)
--
2.4.2
next prev parent reply other threads:[~2015-10-09 20:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 20:47 [PATCH v2 0/7] Qualcomm WCNSS HCI support Bjorn Andersson
2015-10-09 20:47 ` [PATCH v2 1/7] soc: qcom: smd: Introduce callback setter Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 2/7] soc: qcom: smd: Split discovery and state change work Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 3/7] soc: qcom: smd: Refactor channel open and close handling Bjorn Andersson
2015-10-09 20:48 ` Bjorn Andersson [this message]
2015-10-09 20:48 ` [PATCH v2 5/7] soc: qcom: smd: Support opening additional channels Bjorn Andersson
2015-10-14 15:09 ` yfw
2015-10-14 20:53 ` Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 6/7] Bluetooth: Add HCI device identifier for Qualcomm SMD Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 7/7] Bluetooth: btqcomsmd: Qualcomm WCNSS HCI driver Bjorn Andersson
2015-10-09 21:35 ` Marcel Holtmann
2015-10-14 15:10 ` yfw
2015-10-14 20:56 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444423685-14717-5-git-send-email-bjorn.andersson@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=fengwei.yin@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®