From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: yfw <fengwei.yin@linaro.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Andy Gross <agross@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v2 7/7] Bluetooth: btqcomsmd: Qualcomm WCNSS HCI driver
Date: Wed, 14 Oct 2015 13:56:10 -0700 [thread overview]
Message-ID: <20151014205610.GL24668@usrtlx11787.corpusers.net> (raw)
In-Reply-To: <561E7067.2070007@linaro.org>
On Wed 14 Oct 08:10 PDT 2015, yfw wrote:
[..]
> > diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
[..]
> > +static int btqcomsmd_probe(struct qcom_smd_device *sdev)
> > +{
> > + struct qcom_smd_channel *acl;
> > + struct btqcomsmd *btq;
> > + struct hci_dev *hdev;
> > + int ret;
> > +
> > + acl = qcom_smd_open_channel(sdev,
> > + "APPS_RIVA_BT_ACL",
> > + btqcomsmd_acl_callback);
> > + if (IS_ERR(acl))
> > + return PTR_ERR(acl);
> Do we need to close acl channel in following failure path and
> btqcomsmd_remove?
>
As the life cycle of the channels implicitly follow the life cycle of
the qcom_smd_device the channel is supposed to be released by the
caller of probe upon failure.
I'll make sure this is documented in qcom_smd_open_channel()
Thanks for the review.
Regards,
Bjorn
prev parent reply other threads:[~2015-10-14 20:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 20:47 [PATCH v2 0/7] Qualcomm WCNSS HCI support Bjorn Andersson
2015-10-09 20:47 ` [PATCH v2 1/7] soc: qcom: smd: Introduce callback setter Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 2/7] soc: qcom: smd: Split discovery and state change work Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 3/7] soc: qcom: smd: Refactor channel open and close handling Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 4/7] soc: qcom: smd: Support multiple channels per sdev Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 5/7] soc: qcom: smd: Support opening additional channels Bjorn Andersson
2015-10-14 15:09 ` yfw
2015-10-14 20:53 ` Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 6/7] Bluetooth: Add HCI device identifier for Qualcomm SMD Bjorn Andersson
2015-10-09 20:48 ` [PATCH v2 7/7] Bluetooth: btqcomsmd: Qualcomm WCNSS HCI driver Bjorn Andersson
2015-10-09 21:35 ` Marcel Holtmann
2015-10-14 15:10 ` yfw
2015-10-14 20:56 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014205610.GL24668@usrtlx11787.corpusers.net \
--to=bjorn.andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=fengwei.yin@linaro.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®