* [PATCH] VFIO: platform: clear IRQ_NOAUTOEN when de-assigning the IRQ
@ 2015-10-14 15:32 Eric Auger
0 siblings, 0 replies; only message in thread
From: Eric Auger @ 2015-10-14 15:32 UTC (permalink / raw)
To: eric.auger, eric.auger, alex.williamson, b.reynal,
linux-arm-kernel, kvmarm, kvm
Cc: suravee.suthikulpanit, thomas.lendacky, christoffer.dall,
linux-kernel, patches
The vfio platform driver currently sets the IRQ_NOAUTOEN before
doing the request_irq to properly handle the user masking. However
it does not clear it when de-assigning the IRQ. This brings issues
when loading the native driver again which may not explicitly enable
the IRQ. This problem was observed with xgbe driver.
Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
drivers/vfio/platform/vfio_platform_irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c
index 88bba57..46d4750 100644
--- a/drivers/vfio/platform/vfio_platform_irq.c
+++ b/drivers/vfio/platform/vfio_platform_irq.c
@@ -185,6 +185,7 @@ static int vfio_set_trigger(struct vfio_platform_device *vdev, int index,
int ret;
if (irq->trigger) {
+ irq_clear_status_flags(irq->hwirq, IRQ_NOAUTOEN);
free_irq(irq->hwirq, irq);
kfree(irq->name);
eventfd_ctx_put(irq->trigger);
--
1.9.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-14 15:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-14 15:32 [PATCH] VFIO: platform: clear IRQ_NOAUTOEN when de-assigning the IRQ Eric Auger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®