From: Franklin S Cooper Jr <fcooper@ti.com>
To: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
broonie@kernel.org, nsekhar@ti.com, ssantosh@kernel.org,
iivanov@mm-sol.com, m-karicheri2@ti.com, iivanov.xz@gmail.com,
andy.shevchenko@gmail.com, jarkko.nikula@linux.intel.com,
hkallweit1@gmail.com
Cc: Franklin S Cooper Jr <fcooper@ti.com>
Subject: [PATCH] spi: Setup the master controller driver before setting the chipselect
Date: Thu, 15 Oct 2015 15:51:45 -0500 [thread overview]
Message-ID: <1444942305-24038-1-git-send-email-fcooper@ti.com> (raw)
Some devices depend on the master controller driver setup function being
called before calling any chipselect functions.
Insure that this is done otherwise uninitialized structures may be
accessed causing a kernel panic.
Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
Keystone 2 devices currently fail to boot in linux-next after the
below commit was applied:
spi: bitbang: switch to the generic implementation of transfer_one_message
commit: 0037686596832572bbca05ab168d9884d7d704c1
This patch allows Keystone 2 devices to boot again in linux-next.
Tested this patch on K2E evm and am437 starterkit which both have SPI
devices to insure regressions aren't seen.
drivers/spi/spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 4c638f3..9d5525a 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2059,11 +2059,11 @@ int spi_setup(struct spi_device *spi)
if (!spi->max_speed_hz)
spi->max_speed_hz = spi->master->max_speed_hz;
- spi_set_cs(spi, false);
-
if (spi->master->setup)
status = spi->master->setup(spi);
+ spi_set_cs(spi, false);
+
dev_dbg(&spi->dev, "setup mode %d, %s%s%s%s%u bits/w, %u Hz max --> %d\n",
(int) (spi->mode & (SPI_CPOL | SPI_CPHA)),
(spi->mode & SPI_CS_HIGH) ? "cs_high, " : "",
--
2.6.1
next reply other threads:[~2015-10-15 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 20:51 Franklin S Cooper Jr [this message]
2015-10-16 10:28 ` Mark Brown
2015-10-16 14:27 ` Franklin S Cooper Jr.
2015-10-16 14:43 ` Mark Brown
2015-10-16 14:45 ` Franklin S Cooper Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444942305-24038-1-git-send-email-fcooper@ti.com \
--to=fcooper@ti.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=iivanov.xz@gmail.com \
--cc=iivanov@mm-sol.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®