From: Mark Brown <broonie@kernel.org>
To: Franklin S Cooper Jr <fcooper@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
nsekhar@ti.com, ssantosh@kernel.org, iivanov@mm-sol.com,
m-karicheri2@ti.com, iivanov.xz@gmail.com,
andy.shevchenko@gmail.com, jarkko.nikula@linux.intel.com,
hkallweit1@gmail.com
Subject: Re: [PATCH] spi: Setup the master controller driver before setting the chipselect
Date: Fri, 16 Oct 2015 11:28:46 +0100 [thread overview]
Message-ID: <20151016102846.GJ14956@sirena.org.uk> (raw)
In-Reply-To: <1444942305-24038-1-git-send-email-fcooper@ti.com>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On Thu, Oct 15, 2015 at 03:51:45PM -0500, Franklin S Cooper Jr wrote:
> Some devices depend on the master controller driver setup function being
> called before calling any chipselect functions.
>
> Insure that this is done otherwise uninitialized structures may be
> accessed causing a kernel panic.
I think this is a sensible change but can we please have a better
changelog - why is this the best thing to do rather than fixing the
driver to not crash? There are a bunch of good reasons to do the master
setup before asserting chip select but a driver crashing isn't one of
them, it's not clear that this isn't a bug in the driver.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-16 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 20:51 Franklin S Cooper Jr
2015-10-16 10:28 ` Mark Brown [this message]
2015-10-16 14:27 ` Franklin S Cooper Jr.
2015-10-16 14:43 ` Mark Brown
2015-10-16 14:45 ` Franklin S Cooper Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016102846.GJ14956@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=fcooper@ti.com \
--cc=hkallweit1@gmail.com \
--cc=iivanov.xz@gmail.com \
--cc=iivanov@mm-sol.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®