mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: huangdaode <huangdaode@hisilicon.com>
To: <davem@davemloft.net>, <arnd@arndb.de>, <joe@perches.com>
Cc: <liguozhu@hisilicon.com>, <Yisen.Zhuang@huawei.com>,
	<netdev@vger.kernel.org>, <linuxarm@huawei.com>,
	<salil.mehta@huawei.com>, <huangdaode@hisilicon.com>,
	<kenneth-lee-2012@foxmail.com>, <xuwei5@hisilicon.com>,
	<lisheng011@huawei.com>, <linux-kernel@vger.kernel.org>,
	<lipeng321@huawei.com>
Subject: [PATCH net-next v3 1/2] net: hisilicon rm hnae sysfs interface
Date: Fri, 16 Oct 2015 11:54:16 +0800	[thread overview]
Message-ID: <1444967657-107994-2-git-send-email-huangdaode@hisilicon.com> (raw)
In-Reply-To: <1444967657-107994-1-git-send-email-huangdaode@hisilicon.com>

This patch removes the hns driver hnae sysfs interface according to
Arnd's review comments.

Signed-off-by: huangdaode <huangdaode@hisilicon.com>
---
 drivers/net/ethernet/hisilicon/hns/hnae.c | 47 -------------------------------
 1 file changed, 47 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c
index f52e99a..9d3bb83 100644
--- a/drivers/net/ethernet/hisilicon/hns/hnae.c
+++ b/drivers/net/ethernet/hisilicon/hns/hnae.c
@@ -436,59 +436,12 @@ void hnae_ae_unregister(struct hnae_ae_dev *hdev)
 }
 EXPORT_SYMBOL(hnae_ae_unregister);
 
-static ssize_t handles_show(struct device *dev,
-			    struct device_attribute *attr, char *buf)
-{
-	ssize_t s = 0;
-	struct hnae_ae_dev *hdev = cls_to_ae_dev(dev);
-	struct hnae_handle *h;
-	int i = 0, j;
-
-	list_for_each_entry_rcu(h, &hdev->handle_list, node) {
-		s += sprintf(buf + s, "handle %d (eport_id=%u from %s):\n",
-			    i++, h->eport_id, h->dev->name);
-		for (j = 0; j < h->q_num; j++) {
-			s += sprintf(buf + s, "\tqueue[%d] on %p\n",
-				     j, h->qs[i]->io_base);
-#define HANDEL_TX_MSG "\t\ttx_ring on %p:%u,%u,%u,%u,%u,%llu,%llu\n"
-			s += sprintf(buf + s,
-				     HANDEL_TX_MSG,
-				     h->qs[i]->tx_ring.io_base,
-				     h->qs[i]->tx_ring.buf_size,
-				     h->qs[i]->tx_ring.desc_num,
-				     h->qs[i]->tx_ring.max_desc_num_per_pkt,
-				     h->qs[i]->tx_ring.max_raw_data_sz_per_desc,
-				     h->qs[i]->tx_ring.max_pkt_size,
-				 h->qs[i]->tx_ring.stats.sw_err_cnt,
-				 h->qs[i]->tx_ring.stats.io_err_cnt);
-			s += sprintf(buf + s,
-				"\t\trx_ring on %p:%u,%u,%llu,%llu,%llu\n",
-				h->qs[i]->rx_ring.io_base,
-				h->qs[i]->rx_ring.buf_size,
-				h->qs[i]->rx_ring.desc_num,
-				h->qs[i]->rx_ring.stats.sw_err_cnt,
-				h->qs[i]->rx_ring.stats.io_err_cnt,
-				h->qs[i]->rx_ring.stats.seg_pkt_cnt);
-		}
-	}
-
-	return s;
-}
-
-static DEVICE_ATTR_RO(handles);
-static struct attribute *hnae_class_attrs[] = {
-	&dev_attr_handles.attr,
-	NULL,
-};
-ATTRIBUTE_GROUPS(hnae_class);
-
 static int __init hnae_init(void)
 {
 	hnae_class = class_create(THIS_MODULE, "hnae");
 	if (IS_ERR(hnae_class))
 		return PTR_ERR(hnae_class);
 
-	hnae_class->dev_groups = hnae_class_groups;
 	return 0;
 }
 
-- 
1.9.1


  reply	other threads:[~2015-10-16  3:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16  3:54 [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers huangdaode
2015-10-16  3:54 ` huangdaode [this message]
2015-10-16  9:19   ` [PATCH net-next v3 1/2] net: hisilicon rm hnae sysfs interface Arnd Bergmann
2015-10-16  3:54 ` [PATCH net-next v3 2/2] net: hisilicon fix a bug on Hisilicon Network Subsystem huangdaode
2015-10-16  9:30 ` [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers Arnd Bergmann
2015-10-19  2:23   ` huangdaode
2015-10-16  9:30 ` [PATCH] net: hisilicon: include linux/vmalloc.h in dsaf Arnd Bergmann
2015-10-19  2:59   ` David Miller
2015-10-16  9:33 ` [PATCH] net: hisilicon: add OF dependency Arnd Bergmann
2015-10-16 17:03   ` kbuild test robot
2015-10-16 18:16   ` kbuild test robot
2015-10-16 18:22     ` Joe Perches
2015-10-16 18:39   ` kbuild test robot
2015-10-16 19:10     ` Arnd Bergmann
2015-10-19  3:01   ` David Miller
2015-10-16 10:00 ` [PATCH] net: hix5hd2_gmac: avoid integer overload warning Arnd Bergmann
2015-10-16 11:14   ` David Laight
2015-10-16 11:28     ` Arnd Bergmann
2015-10-16 18:04       ` Joe Perches
2015-10-16 18:50         ` Sergei Shtylyov
2015-10-16 21:22           ` Joe Perches
2015-10-16 21:42             ` Arnd Bergmann
2015-10-19  3:01   ` David Miller
2015-10-19  2:55 ` [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444967657-107994-2-git-send-email-huangdaode@hisilicon.com \
    --to=huangdaode@hisilicon.com \
    --cc=Yisen.Zhuang@huawei.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=kenneth-lee-2012@foxmail.com \
    --cc=liguozhu@hisilicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=lipeng321@huawei.com \
    --cc=lisheng011@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®