From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: huangdaode@hisilicon.com, joe@perches.com,
liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com,
netdev@vger.kernel.org, linuxarm@huawei.com,
salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com,
xuwei5@hisilicon.com, lisheng011@huawei.com,
linux-kernel@vger.kernel.org, lipeng321@huawei.com
Subject: Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning
Date: Sun, 18 Oct 2015 20:01:45 -0700 (PDT) [thread overview]
Message-ID: <20151018.200145.258165069418211324.davem@davemloft.net> (raw)
In-Reply-To: <4752736.dePgPCNd9q@wuerfel>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 16 Oct 2015 12:00:51 +0200
> BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that
> has bits set that do not fit into a 32-bit variable on 64-bit architectures,
> which causes a harmless gcc warning:
>
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c: In function 'hix5hd2_port_disable':
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c:374:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> writel_relaxed(~(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN);
>
> This adds a cast to (u32) to tell gcc that the code is indeed fine.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
next prev parent reply other threads:[~2015-10-19 2:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 3:54 [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers huangdaode
2015-10-16 3:54 ` [PATCH net-next v3 1/2] net: hisilicon rm hnae sysfs interface huangdaode
2015-10-16 9:19 ` Arnd Bergmann
2015-10-16 3:54 ` [PATCH net-next v3 2/2] net: hisilicon fix a bug on Hisilicon Network Subsystem huangdaode
2015-10-16 9:30 ` [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers Arnd Bergmann
2015-10-19 2:23 ` huangdaode
2015-10-16 9:30 ` [PATCH] net: hisilicon: include linux/vmalloc.h in dsaf Arnd Bergmann
2015-10-19 2:59 ` David Miller
2015-10-16 9:33 ` [PATCH] net: hisilicon: add OF dependency Arnd Bergmann
2015-10-16 17:03 ` kbuild test robot
2015-10-16 18:16 ` kbuild test robot
2015-10-16 18:22 ` Joe Perches
2015-10-16 18:39 ` kbuild test robot
2015-10-16 19:10 ` Arnd Bergmann
2015-10-19 3:01 ` David Miller
2015-10-16 10:00 ` [PATCH] net: hix5hd2_gmac: avoid integer overload warning Arnd Bergmann
2015-10-16 11:14 ` David Laight
2015-10-16 11:28 ` Arnd Bergmann
2015-10-16 18:04 ` Joe Perches
2015-10-16 18:50 ` Sergei Shtylyov
2015-10-16 21:22 ` Joe Perches
2015-10-16 21:42 ` Arnd Bergmann
2015-10-19 3:01 ` David Miller [this message]
2015-10-19 2:55 ` [PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018.200145.258165069418211324.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yisen.Zhuang@huawei.com \
--cc=arnd@arndb.de \
--cc=huangdaode@hisilicon.com \
--cc=joe@perches.com \
--cc=kenneth-lee-2012@foxmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®