* [PATCH] fault-inject: fix inverted interval/probability values in printk
@ 2015-10-17 8:51 Florian Westphal
2015-10-19 14:21 ` Akinobu Mita
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2015-10-17 8:51 UTC (permalink / raw)
To: akinobu.mita; +Cc: dmonakhov, linux-kernel, Florian Westphal
interval displays the probability and vice versa.
Fixes: 6adc4a22f20bb ("fault-inject: add ratelimit option")
Signed-off-by: Florian Westphal <fw@strlen.de>
---
lib/fault-inject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/fault-inject.c b/lib/fault-inject.c
index f1cdeb0..6a823a5 100644
--- a/lib/fault-inject.c
+++ b/lib/fault-inject.c
@@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
"name %pd, interval %lu, probability %lu, "
"space %d, times %d\n", attr->dname,
- attr->probability, attr->interval,
+ attr->interval, attr->probability,
atomic_read(&attr->space),
atomic_read(&attr->times));
if (attr->verbose > 1)
--
2.0.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fault-inject: fix inverted interval/probability values in printk
2015-10-17 8:51 [PATCH] fault-inject: fix inverted interval/probability values in printk Florian Westphal
@ 2015-10-19 14:21 ` Akinobu Mita
0 siblings, 0 replies; 2+ messages in thread
From: Akinobu Mita @ 2015-10-19 14:21 UTC (permalink / raw)
To: Florian Westphal, Andrew Morton; +Cc: Dmitry Monakhov, LKML
2015-10-17 17:51 GMT+09:00 Florian Westphal <fw@strlen.de>:
> interval displays the probability and vice versa.
>
> Fixes: 6adc4a22f20bb ("fault-inject: add ratelimit option")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Looks good to me.
Acked-by: Akinobu Mita <akinobu.mita@gmail.com>
Andrew, could you consider to merge this patch to your tree?
> ---
> lib/fault-inject.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index f1cdeb0..6a823a5 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
> printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
> "name %pd, interval %lu, probability %lu, "
> "space %d, times %d\n", attr->dname,
> - attr->probability, attr->interval,
> + attr->interval, attr->probability,
> atomic_read(&attr->space),
> atomic_read(&attr->times));
> if (attr->verbose > 1)
> --
> 2.0.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-19 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-17 8:51 [PATCH] fault-inject: fix inverted interval/probability values in printk Florian Westphal
2015-10-19 14:21 ` Akinobu Mita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®