From: Johannes Thumshirn <jthumshirn@suse.de>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ondrej Zary <linux@rainbow-software.org>
Subject: Re: [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE
Date: Thu, 22 Oct 2015 09:22:47 +0200 [thread overview]
Message-ID: <1445498567.16404.18.camel@suse.de> (raw)
In-Reply-To: <1445466207-23265-1-git-send-email-falakreyaz@gmail.com>
On Thu, 2015-10-22 at 03:53 +0530, Muhammad Falak R Wani wrote:
> Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
> the goal of getting rid of this macro completely, as this macro
> is deprecated.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/scsi/wd719x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
> index e3da1a2..2a9da2e 100644
> --- a/drivers/scsi/wd719x.c
> +++ b/drivers/scsi/wd719x.c
> @@ -962,7 +962,7 @@ static void wd719x_pci_remove(struct pci_dev
> *pdev)
> scsi_host_put(sh);
> }
>
> -static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = {
> +static const struct pci_device_id wd719x_pci_table[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) },
> {}
> };
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
next prev parent reply other threads:[~2015-10-22 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 22:23 Muhammad Falak R Wani
2015-10-22 7:22 ` Johannes Thumshirn [this message]
2015-10-22 11:32 ` Vaishali Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445498567.16404.18.camel@suse.de \
--to=jthumshirn@suse.de \
--cc=JBottomley@odin.com \
--cc=falakreyaz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome